fix: Rewrite infinite queries to be consist using undefined over null #3637

nicholas-codecov · 2025-01-07T17:02:20Z

Description

This PR is a quick fix to ensure that these infinite query options are more consist in the way they handle pageParam's to reduce potential issues down the road, the docs in notion have also been updated accordingly.

Notable Changes

Update all TS Query V5 implementations that differ

codecov-staging · 2025-01-07T17:04:56Z

Bundle Report

Changes will increase total bundle size by 175 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	6.06MB	89 bytes (0.0%) ⬆️
gazebo-staging-system	6.0MB	86 bytes (0.0%) ⬆️

codecov-qa · 2025-01-07T17:05:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (23e4bfd) to head (bce15a2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3637   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         811      811           
  Lines       14566    14567    +1     
  Branches     4139     4141    +2     
=======================================
+ Hits        14413    14414    +1     
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.36% <100.00%> (+0.07%)`	⬆️
src/services/repos/ReposQueryOpts.tsx	`100.00% <100.00%> (ø)`
src/services/repos/ReposTeamQueryOpts.tsx	`100.00% <100.00%> (ø)`
...services/selfHosted/SelfHostedUserListQueryOpts.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (+<0.01%)`	⬆️
Services	`99.33% <100.00%> (-0.01%)`	⬇️
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...bce15a2. Read the comment docs.

codecov-public-qa · 2025-01-07T17:05:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (23e4bfd) to head (bce15a2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3637   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         811      811           
  Lines       14566    14567    +1     
  Branches     4139     4141    +2     
=======================================
+ Hits        14413    14414    +1     
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.36% <100.00%> (+0.07%)`	⬆️
src/services/repos/ReposQueryOpts.tsx	`100.00% <100.00%> (ø)`
src/services/repos/ReposTeamQueryOpts.tsx	`100.00% <100.00%> (ø)`
...services/selfHosted/SelfHostedUserListQueryOpts.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (+<0.01%)`	⬆️
Services	`99.33% <100.00%> (-0.01%)`	⬇️
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...bce15a2. Read the comment docs.

codecov · 2025-01-07T17:05:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (23e4bfd) to head (bce15a2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3637   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         811      811           
  Lines       14566    14567    +1     
  Branches     4139     4134    -5     
=======================================
+ Hits        14413    14414    +1     
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.36% <100.00%> (+0.07%)`	⬆️
src/services/repos/ReposQueryOpts.tsx	`100.00% <100.00%> (ø)`
src/services/repos/ReposTeamQueryOpts.tsx	`100.00% <100.00%> (ø)`
...services/selfHosted/SelfHostedUserListQueryOpts.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (+<0.01%)`	⬆️
Services	`99.33% <100.00%> (-0.01%)`	⬇️
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...bce15a2. Read the comment docs.

codecov · 2025-01-07T17:05:54Z

Bundle Report

Changes will increase total bundle size by 175 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.0MB	86 bytes (0.0%) ⬆️
gazebo-production-system-esm	6.06MB	89 bytes (0.0%) ⬆️

codecov-releaser · 2025-01-07T17:08:15Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`bce15a2`	Tue, 07 Jan 2025 17:08:15 GMT	Cloud	Enterprise

codecov-notifications · 2025-01-07T17:08:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3637   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         811      811           
  Lines       14566    14567    +1     
  Branches     4139     4141    +2     
=======================================
+ Hits        14413    14414    +1     
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.36% <100.00%> (+0.07%)`	⬆️
src/services/repos/ReposQueryOpts.tsx	`100.00% <100.00%> (ø)`
src/services/repos/ReposTeamQueryOpts.tsx	`100.00% <100.00%> (ø)`
...services/selfHosted/SelfHostedUserListQueryOpts.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (+<0.01%)`	⬆️
Services	`99.33% <100.00%> (-0.01%)`	⬇️
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...bce15a2. Read the comment docs.

nicholas-codecov added 5 commits January 7, 2025 11:54

update InfiniteAccountOrganizationsQueryOpts

14ba508

update BundleAssetsQueryOpts

df83c2e

update ReposQueryOpts

8a4e1fe

update ReposTeamQueryOpts

a8f0259

update SelfHostedUserListQueryOpts

bce15a2

spalmurray-codecov approved these changes Jan 7, 2025

View reviewed changes

nicholas-codecov added this pull request to the merge queue Jan 7, 2025

Merged via the queue into main with commit b598ce1 Jan 7, 2025
62 checks passed

nicholas-codecov deleted the fix-rewrite-infinite-queries-to-be-consist-using-undefined-over-null branch January 7, 2025 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Rewrite infinite queries to be consist using undefined over null #3637

fix: Rewrite infinite queries to be consist using undefined over null #3637

nicholas-codecov commented Jan 7, 2025

codecov-staging bot commented Jan 7, 2025 •

edited

Loading

codecov-qa bot commented Jan 7, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 7, 2025 •

edited

Loading

codecov bot commented Jan 7, 2025 •

edited

Loading

codecov bot commented Jan 7, 2025

codecov-releaser commented Jan 7, 2025

codecov-notifications bot commented Jan 7, 2025 •

edited

Loading

fix: Rewrite infinite queries to be consist using undefined over null #3637

fix: Rewrite infinite queries to be consist using undefined over null #3637

Conversation

nicholas-codecov commented Jan 7, 2025

Description

Notable Changes

codecov-staging bot commented Jan 7, 2025 • edited Loading

Bundle Report

codecov-qa bot commented Jan 7, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Jan 7, 2025 • edited Loading

Codecov Report

codecov bot commented Jan 7, 2025 • edited Loading

Codecov Report

codecov bot commented Jan 7, 2025

Bundle Report

codecov-releaser commented Jan 7, 2025

✅ Deploy preview for gazebo ready!

codecov-notifications bot commented Jan 7, 2025 • edited Loading

Codecov Report

codecov-staging bot commented Jan 7, 2025 •

edited

Loading

codecov-qa bot commented Jan 7, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 7, 2025 •

edited

Loading

codecov bot commented Jan 7, 2025 •

edited

Loading

codecov-notifications bot commented Jan 7, 2025 •

edited

Loading