Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step3five #191

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/api.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: API workflow

on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
name: Test python API
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install requirements
run: pip install -r api/requirements.txt
- name: Run tests and collect coverage
run: pytest --cov=api.calculator --cov-report=xml
- name: Upload coverage reports to Codecov with GitHub Action
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
35 changes: 35 additions & 0 deletions api/app.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
from flask import (
Flask,
request,
)

from calculator.calculator import Calculator

app = Flask(__name__)

@app.route('/api/add', methods=['POST'])
def add():
return operation('add', 2)

@app.route('/api/subtract', methods=['POST'])
def subtract():
return operation('subtract', 2)

@app.route('/api/multiply', methods=['POST'])
def multiply():
return operation('multiply', 2)

@app.route('/api/divide', methods=['POST'])
def divide():
return operation('divide', 2)

def operation(method, num_factors):
factors = []
if num_factors == 2:
factors.append(float(request.json.get('x')))
factors.append(float(request.json.get('y')))

return str(getattr(Calculator, method)(*factors))


app.run(host='0.0.0.0', port=8080)
Empty file added api/calculator/__init__.py
Empty file.
14 changes: 14 additions & 0 deletions api/calculator/calculator.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
class Calculator:
def add(x, y):
return x + y

def subtract(x, y):
return x - y

def multiply(x, y):
return x * y

def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y
33 changes: 33 additions & 0 deletions api/calculator/test_calculator.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
from .calculator import Calculator


def test_add():
assert Calculator.add(1, 2) == 3.0
assert Calculator.add(1.0, 2.0) == 3.0
assert Calculator.add(0, 2.0) == 2.0
assert Calculator.add(2.0, 0) == 2.0
assert Calculator.add(-4, 2.0) == -2.0

# def test_subtract():
# assert Calculator.subtract(1, 2) == -1.0
# assert Calculator.subtract(2, 1) == 1.0
# assert Calculator.subtract(1.0, 2.0) == -1.0
# assert Calculator.subtract(0, 2.0) == -2.0
# assert Calculator.subtract(2.0, 0.0) == 2.0
# assert Calculator.subtract(-4, 2.0) == -6.0

# def test_multiply():
# assert Calculator.multiply(1, 2) == 2.0
# assert Calculator.multiply(1.0, 2.0) == 2.0
# assert Calculator.multiply(0, 2.0) == 0.0
# assert Calculator.multiply(2.0, 0.0) == 0.0
# assert Calculator.multiply(-4, 2.0) == -8.0

# def test_divide():
# assert Calculator.divide(1, 2) == 0.5
# assert Calculator.divide(1.0, 2.0) == 0.5
# assert Calculator.divide(0, 2.0) == 0
# assert Calculator.divide(-4, 2.0) == -2.0

def test_divide_by_0():
assert Calculator.divide(2.0, 0) == 'Cannot divide by 0'
25 changes: 25 additions & 0 deletions api/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
attrs==22.1.0
autopep8==2.0.1
certifi==2022.12.7
charset-normalizer==3.1.0
click==8.1.3
coverage==6.4.2
coveralls==3.3.1
docopt==0.6.2
Flask==2.2.1
idna==3.4
iniconfig==1.1.1
itsdangerous==2.1.2
Jinja2==3.1.2
MarkupSafe==2.1.1
packaging==21.3
pluggy==1.0.0
py==1.11.0
pycodestyle==2.10.0
pyparsing==3.0.9
pytest==7.1.2
pytest-cov==3.0.0
requests==2.28.2
tomli==2.0.1
urllib3==1.26.15
Werkzeug==2.2.1
14 changes: 14 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
coverage:
status:
project:
default:
target: 80%
threshold: 1%
informational: true
patch:
default:
target: 80%
threshold: 1%
informational: true
ignore:
- "**/test_*.py"
Loading