Improve logging and remove an else

code-lts · Dec 3, 2023 · 4d5bf5d · 4d5bf5d
1 parent c09ba02
commit 4d5bf5d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Resumable.php b/src/Resumable.php
@@ -303,8 +303,8 @@ public function handleChunk()
 
         if ($this->isFileUploadComplete($filename, $identifier, $chunkSize, $totalSize)) {
             $this->isUploadComplete = true;
-            $this->createFileAndDeleteTmp($identifier, $filename);
             $this->log('Upload of ' . $identifier . ' is complete');
+            $this->createFileAndDeleteTmp($identifier, $filename);
         }
 
         return $this->response->withStatus(201);
@@ -319,11 +319,12 @@ private function createFileAndDeleteTmp(string $identifier, ?string $filename):
         $chunkFiles = $this->fileSystem->listKeys(
             $chunkDir
         )['keys'];
+
+        $finalFilename = $filename;
+
         // if the user has set a custom filename
         if (null !== $this->filename) {
             $finalFilename = $this->createSafeFilename($this->filename, $filename);
-        } else {
-            $finalFilename = $filename;
         }
 
         // replace filename reference by the final file