Add type check framework #1981
Closed
Add type check framework #1981
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an explicit type so that tsc does not infer that `no-pod` is a required property. This led to > src/Containers.jsx(668,24): error TS2790: The operand of a 'delete' operator must be optional. Declaring it explicitly states that all keys are optional.
Copied from current cockpit-files.
|
@jelly I'm making more typescript things in a branch on top of that, so far it's a nice learning exercise (and found a bug). But you mentioned you had doubts here, so if you don't like this please reject now and I'll put this to rest. |
Closed
|
See #1987 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to do bigger changes to podman's code base. Before I start that, I'd like to TSify at least the basals, like src/client.js (not necessarily the top-level components).