Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.13 #641

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Support python 3.13 #641

merged 3 commits into from
Jan 9, 2025

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Dec 30, 2024

  • Replace Python 3.12 by Python 3.13 as the default
  • Update pixi.lock
  • Test Python 3.13 in CI

@Moisan
Copy link
Contributor Author

Moisan commented Dec 31, 2024

I see that scipy, which is a transitive dependency through eigenpy, started supporting Python 3.13 in release 4.14.1 and dropped support for python 3.9 in release 4.14.0. Hence, if we want to support Python 3.13, we would need to drop Python 3.9 support.

@nim65s
Copy link
Contributor

nim65s commented Dec 31, 2024

no, we can depend on scipy 4.14.1 for python 3.13 and on scipy 4.13 for python 3.9

@Moisan Moisan force-pushed the python-3.13-support branch from 7fc0c9e to fc22225 Compare December 31, 2024 16:31
jorisv
jorisv requested changes Jan 3, 2025
View reviewed changes
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
@Moisan Moisan force-pushed the python-3.13-support branch from fc22225 to cee8fe8 Compare January 3, 2025 14:33
jorisv
jorisv previously approved these changes Jan 3, 2025
View reviewed changes
@jorisv jorisv force-pushed the python-3.13-support branch from cee8fe8 to 8db40ae Compare January 6, 2025 08:34
@jorisv
Copy link
Contributor

jorisv commented Jan 6, 2025

@Moisan I have rebase your branch on devel.

@jcarpent jcarpent force-pushed the python-3.13-support branch from 8db40ae to c2a757a Compare January 7, 2025 16:24
jorisv
jorisv previously approved these changes Jan 9, 2025
View reviewed changes
@jorisv jorisv force-pushed the python-3.13-support branch from c2a757a to aebda6e Compare January 9, 2025 11:05
@jorisv jorisv requested a review from nim65s January 9, 2025 11:05
jorisv
jorisv previously approved these changes Jan 9, 2025
View reviewed changes
@jorisv jorisv force-pushed the python-3.13-support branch from 113a66b to 3631ccf Compare January 9, 2025 11:10
jorisv
jorisv previously approved these changes Jan 9, 2025
View reviewed changes
nim65s
nim65s previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for pip part

@jorisv jorisv dismissed stale reviews from nim65s and themself via 732d1c9 January 9, 2025 13:03
@jorisv jorisv force-pushed the python-3.13-support branch from 3631ccf to 732d1c9 Compare January 9, 2025 13:03
@jorisv jorisv merged commit 5aa4305 into coal-library:devel Jan 9, 2025
34 of 38 checks passed
@jorisv
Copy link
Contributor

jorisv commented Jan 9, 2025

Merged.

@Moisan thank's for the contribution.

@Moisan Moisan deleted the python-3.13-support branch January 9, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisv jorisv jorisv approved these changes

@nim65s nim65s nim65s left review comments

Assignees

@jorisv jorisv

Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @nim65s @jorisv