Remove unneccesary link targets as they are propagated automatically

The new way of cmake is automatic propagation and inheritance of compiler flags and linker arguments based on PUBLIC, PRIVATE, an INTERFACE arguments in the target commands. Signed-off-by: Christoph Niethammer <[email protected]>
cniethammer · Dec 13, 2024 · cbe6a66 · cbe6a66
1 parent 8da7e45
commit cbe6a66
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -85,10 +85,9 @@ else (WS_PARALLEL)
     SET(PARLIB "")
 endif (WS_PARALLEL)
 
-ADD_SUBDIRECTORY(${workspace_SOURCE_DIR}/external/yaml-cpp)
+add_subdirectory(${workspace_SOURCE_DIR}/external/yaml-cpp)
 add_subdirectory(${workspace_SOURCE_DIR}/external/rapidyaml ryml)
-include_directories(${RYAML_INCLUDE_DIR})
-ADD_SUBDIRECTORY(${workspace_SOURCE_DIR}/external/fmt)
+add_subdirectory(${workspace_SOURCE_DIR}/external/fmt)
 
 get_directory_property(LINKER_VAR LINK_DIRECTORIES)
 message(STATUS "LINKER_VAR: ${LINKER_VAR}")
@@ -125,13 +124,13 @@ ADD_LIBRARY(ws_common OBJECT
 	${workspace_SOURCE_DIR}/src/caps.cpp
 	)
 
-TARGET_LINK_LIBRARIES(ws_common PUBLIC yaml-cpp::yaml-cpp fmt::fmt ryml::ryml c4core::c4core)
+TARGET_LINK_LIBRARIES(ws_common PUBLIC yaml-cpp::yaml-cpp fmt::fmt ryml::ryml)
 
 ADD_EXECUTABLE( ws_list ${workspace_SOURCE_DIR}/src/ws_list.cpp )
-TARGET_LINK_LIBRARIES( ws_list "-L${LINKER_VAR}" ws_common ${Boost_LIBRARIES} ${EXTRA_STATIC_LIBS} ${LIBCAP} yaml-cpp::yaml-cpp fmt::fmt ryml::ryml c4core::c4core ${PARLIB})
+TARGET_LINK_LIBRARIES( ws_list "-L${LINKER_VAR}" ws_common ${Boost_LIBRARIES} ${EXTRA_STATIC_LIBS} ${LIBCAP} fmt::fmt ${PARLIB})
 
 ADD_EXECUTABLE( ws_allocate ${workspace_SOURCE_DIR}/src/ws_allocate.cpp )
-TARGET_LINK_LIBRARIES( ws_allocate "-L${LINKER_VAR}" ws_common ${Boost_LIBRARIES} ${EXTRA_STATIC_LIBS} ${LIBCAP} yaml-cpp::yaml-cpp fmt::fmt ryml::ryml c4core::c4core ${PARLIB})
+TARGET_LINK_LIBRARIES( ws_allocate "-L${LINKER_VAR}" ws_common ${Boost_LIBRARIES} ${EXTRA_STATIC_LIBS} ${LIBCAP} fmt::fmt ${PARLIB})