-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Go modules #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks a lot @radu-matei for handling that !
I don't have permission in circle to enable this, but I can approve it on the GH side once requested. https://circleci.com/docs/2.0/enable-checks/ I think that's what needs to happen, want to give it a go @silvin-lubecki ? |
@radu-matei I believe I've enabled the circleci app now; can you try re-triggering with a fresh push? |
The build failed 🤔
|
@silvin-lubecki - and there's another transient error, #98. |
Signed-off-by: Radu M <[email protected]>
We should not merge until we have working (and passing) CI.
Edit: it turns out Circle is actually running the builds, but not reporting back to GitHub because maybe it's not authorized - https://circleci.com/gh/cnabio/cnab-to-oci/300