Fix certificate retrieval bugs for players who had nonscoring games

cmu-sei · Jan 21, 2025 · f6859f1 · f6859f1
1 parent ef2cadb
commit f6859f1
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/Gameboard.Api/Features/Certificates/CertificatesService.cs b/src/Gameboard.Api/Features/Certificates/CertificatesService.cs
@@ -78,11 +78,10 @@ public async Task<IEnumerable<CompetitiveModeCertificate>> GetCompetitiveCertifi
             .WithNoTracking<Data.Player>()
             .Where
             (
-                p => p.UserId == userId &&
-                p.SessionEnd > DateTimeOffset.MinValue &&
-                p.Game.PlayerMode == PlayerMode.Competition &&
-                (p.Game.GameEnd < now || p.Game.GameEnd == DateTimeOffset.MinValue) &&
-                p.Game.CertificateTemplateId != null
+                p =>
+                    p.UserId == userId
+                    && (p.Game.GameEnd < now || p.Game.GameEnd == DateTimeOffset.MinValue)
+            // && p.Game.CertificateTemplateId != null
             )
             .WhereDateIsNotEmpty(p => p.SessionEnd)
             .Where(p => p.Challenges.All(c => c.PlayerMode == PlayerMode.Competition))
@@ -159,7 +158,7 @@ public async Task<IEnumerable<CompetitiveModeCertificate>> GetCompetitiveCertifi
                     MaxPossibleScore = t.Game.MaxPossibleScore
                 },
                 Date = t.Game.GameEnd.IsEmpty() ? captain.SessionEnd : t.Game.GameEnd,
-                Rank = score.Rank > 0 ? score.Rank : null,
+                Rank = score?.Rank ?? 0,
                 Score = score is not null ? score.ScoreOverall : 0,
                 Duration = TimeSpan.FromMilliseconds(t.Time),
                 UniquePlayerCount = participationCounts?.UniquePlayerCount,