Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 21 #410

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Upgrade to Java 21 #410

merged 7 commits into from
Dec 13, 2023

Conversation

bpkroth
Copy link
Collaborator

@bpkroth bpkroth commented Dec 7, 2023 •
edited
Loading

Separates a conversion to Java 21 from #398 and also handles errors encountered in #369.

@bpkroth bpkroth added enhancement New feature or request dependencies Pull requests that update a dependency file in-progress This PR is in progress. labels Dec 7, 2023
This was referenced Dec 8, 2023
Closed
Closed
Merged
@bpkroth bpkroth changed the title WIP: Java 21 upgrade and enable compiler warnings Upgrade to Java 21 Dec 8, 2023
@bpkroth bpkroth marked this pull request as ready for review December 8, 2023 15:45
@bpkroth bpkroth added bug Something isn't working and removed enhancement New feature or request in-progress This PR is in progress. labels Dec 8, 2023
@bpkroth bpkroth linked an issue Dec 8, 2023 that may be closed by this pull request
GetInterfaces test in TestClassUtil.java appears to be checking interfaces of Java builtins? #369
Closed
@bpkroth
Copy link
Collaborator Author

bpkroth commented Dec 8, 2023

@apavlo staging this as a smaller change, but there's a few other related ones.
Main concern here is that it is potentially a breaking change for folks using just the jar release, so we should probably also tag a new release commit once this is merged.
This change also incorporates a new version tag in the relevant files to match that.
Let me know if you have any other thoughts.

@bpkroth bpkroth requested a review from apavlo December 8, 2023 15:49
@bpkroth bpkroth mentioned this pull request Dec 8, 2023
Closed
@bpkroth
Copy link
Collaborator Author

bpkroth commented Dec 13, 2023

@apavlo staging this as a smaller change, but there's a few other related ones. Main concern here is that it is potentially a breaking change for folks using just the jar release, so we should probably also tag a new release commit once this is merged. This change also incorporates a new version tag in the relevant files to match that. Let me know if you have any other thoughts.

Discussed offline. Gonna merge this now and tag a new release. Thanks!

@bpkroth bpkroth merged commit b4b3668 into cmu-db:main Dec 13, 2023
121 checks passed
@bpkroth bpkroth deleted the java-21 branch December 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apavlo apavlo Awaiting requested review from apavlo

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetInterfaces test in TestClassUtil.java appears to be checking interfaces of Java builtins?
1 participant
@bpkroth