Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: temporarily revert the BTL numbering scheme update #47115

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fabiocos
Copy link
Contributor

PR description:

Following the issue mentioned in #47114 as a consequence of the update of the BTL numbering scheme and BTLDetId data format in the PR #46977 , the update is temporarily reverted, pending a solution that protects against the residual backward compatibility violations.

PR validation:

Simple revert of the PR without further developments on top of it, code compiles. It requires reverting also the data files used as references of the unit tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • DataFormats/ForwardDetId (upgrade, simulation)
  • DataFormats/TrackReco (reconstruction)
  • Geometry/MTDCommonData (upgrade, geometry)
  • Geometry/MTDGeometryBuilder (upgrade, geometry)
  • Geometry/MTDNumberingBuilder (upgrade, geometry)
  • RecoMTD/DetLayers (upgrade, reconstruction)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @apsallid, @bsunanda, @denizsun, @gpetruc, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @salimcerci, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#19

@fabiocos
Copy link
Contributor Author

type fix

@fabiocos
Copy link
Contributor Author

type mtd

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dc84d/43794/summary.html
COMMIT: f400f7c
CMSSW: CMSSW_15_0_X_2025-01-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47115/43794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants