Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications for Pythia 8.313 #47092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mseidel42
Copy link
Contributor

@mseidel42 mseidel42 commented Jan 13, 2025

PR description:

Needs cms-sw/cmsdist#9612

Pythia 8.313 requires

  • ParticleDecays:allowPhotonRadiation -> HadronLevel:QED
  • Tune:preferLHAPDF = 0 when an internal Pythia PDF is used

PR validation:

Pass    3s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareIdentical
Pass    5s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareExternal
Pass   10s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareExternalStreams
Pass   12s ... GeneratorInterface/Pythia8Interface/testGeneratorInterfacePythia8InterfaceTP
Pass   18s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_bplus
Pass   20s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_external_bplus
Pass   28s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8ConcurrentGeneratorFilter
Pass   46s ... GeneratorInterface/EvtGenInterface/GeneratorInterfaceEvtGenInterfaceTest
>> Test sequence completed for CMSSW CMSSW_15_0_0_pre1   

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mseidel42 for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/EvtGenInterface (generators)
  • GeneratorInterface/PhotosInterface (generators)
  • GeneratorInterface/Pythia8Interface (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @fabiocos, @missirol, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47092 was updated. @bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please check and sign again.

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#9612

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585dc6/43854/summary.html
COMMIT: 2fa94cf
CMSSW: CMSSW_15_0_X_2025-01-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47092/43854/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585dc6/43854/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585dc6/43854/git-merge-result

Comparison Summary

Summary:

  • You potentially added 62 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 72775 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3817749
  • DQMHistoTests: Total failures: 466066
  • DQMHistoTests: Total nulls: 333
  • DQMHistoTests: Total successes: 3351330
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -677.2280000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.629 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0 ): -677.346 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.127 KiB SiStrip/MechanicalView
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 15 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants