check for repeat detIDs when converting clusters from SoA #47076
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47076/43248 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47076/43256 |
|
A new Pull Request was created by @mroguljic for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
@mroguljic can you please squash the commits ? |
mroguljic
force-pushed
the
pixel_clusterizer_fix
branch
from
eb5626e to
f62a42f
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47076/43257 |
|
Pull request #47076 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again. |
|
@cmsbuild, please test |
|
I have been testing this with the reproducer at #46783 (comment) (modified to run over all the error stream files that we have for the two runs in question):
#!/bin/bash -ex
# List of run numbers
runs=(
388769
388770
)
# Base directory for input files on EOS
base_dir="/store/group/tsg/FOG/error_stream_root/run"
# Global tag for the HLT configuration
global_tag="141X_dataRun3_HLT_v2"
# EOS command (adjust this if necessary for your environment)
eos_cmd="eos"
# Loop over each run number
for run in "${runs[@]}"; do
# Construct the input directory path
input_dir="${base_dir}${run}"
# Find all root files in the input directory on EOS
root_files=$(${eos_cmd} find -f "/eos/cms${input_dir}" -name "*.root" | awk '{print "root://eoscms.cern.ch/" $0}' | paste -sd, -)
# Check if there are any root files found
if [ -z "${root_files}" ]; then
echo "No root files found for run ${run} in directory ${input_dir}."
continue
fi
# Create filenames for the HLT configuration and log file
hlt_config_file="hlt_run${run}.py"
hlt_log_file="hlt_run${run}.log"
# Generate the HLT configuration file
hltGetConfiguration run:${run} \
--globaltag ${global_tag} \
--data \
--no-prescale \
--no-output \
--max-events -1 \
--path HLT_HIUPC_DoubleEG5_BptxAND_SinglePixelTrack_MaxPixelTrack_v* \
--input ${root_files} > ${hlt_config_file}
# Append additional options to the configuration file
cat <<@EOF >> ${hlt_config_file}
del process.MessageLogger
process.load('FWCore.MessageService.MessageLogger_cfi')
process.options.wantSummary = True
process.options.numberOfThreads = 1
process.options.numberOfStreams = 0
@EOF
# Run the HLT configuration with cmsRun and redirect output to log file
cmsRun ${hlt_config_file} &> ${hlt_log_file}
donethe processing fails at event 781 with the following assertion: The same thing happens when I try the reproducer from the related issue: #47021 (comment). This fix thus looks incomplete. Please take a look. |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
Pull request has been put on hold by @mmusich |
PR description:
Fix for HLT crashses reported here: #46783
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 14_1_X