Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Create MCMultiParticleMassFilter.cc #47057

Open
wants to merge 1 commit into
base: CMSSW_10_6_X
Choose a base branch
from

Conversation

MohitS704
Copy link
Contributor

A version of #46856, but for a CMSSW compatible with slc7. This is for the re-production of Run 2 Monte Carlo sometime in the future. As such, the MCMultiParticleMassFilter needs to be backported from el9 to slc7 as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

A new Pull Request was created by @MohitS704 for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

cms-bot internal usage

@bbilin
Copy link
Contributor

bbilin commented Jan 13, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0610/43736/summary.html
COMMIT: 0aeef9c
CMSSW: CMSSW_10_6_X_2025-01-12-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47057/43736/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215349
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@lviliani
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen mandrenguyen changed the title backporting to an slc7 CMSSW [10_6_X] Create MCMultiParticleMassFilter.cc Jan 16, 2025
@mandrenguyen
Copy link
Contributor

backport of #46856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants