Replace `TAcc` with explicit accelerator type #46916

fwyzard · 2024-12-11T17:24:33Z

PR description:

Replace the TAcc template with the explicit accelerator type (Acc1D, Acc2D, or Acc3D).

PR validation:

The code builds.

fwyzard · 2024-12-11T17:24:39Z

please test

cmsbuild · 2024-12-11T17:24:59Z

cms-bot internal usage

cmsbuild · 2024-12-11T17:27:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46916/42977

There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Add {Copy,Move}ToDeviceCache<T> class templates and moveToDeviceAsync function template #43969
- File RecoLocalCalo/HGCalRecProducers/plugins/alpaka/HGCalLayerClustersSoAAlgoWrapper.dev.cc modified in PR(s): ALPAKA CLUE2D Code Heterogenous Code Porting #46786

cmsbuild · 2024-12-11T17:27:28Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
DataFormats/TrackSoA (heterogeneous, reconstruction)
DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)
DataFormats/VertexSoA (heterogeneous, reconstruction)
EventFilter/EcalRawToDigi (reconstruction)
HeterogeneousCore/AlpakaInterface (heterogeneous)
HeterogeneousCore/AlpakaTest (heterogeneous)
MagneticField/ParametrizedEngine (reconstruction)
RecoLocalCalo/EcalRecProducers (reconstruction)
RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
RecoLocalCalo/HcalRecProducers (reconstruction)

@Moanwar, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abdoulline, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @dkotlins, @edjtscott, @felicepantaleo, @ferencek, @gpetruc, @hatakeyamak, @lecriste, @lgray, @makortel, @mariadalfonso, @missirol, @mmusich, @mroguljic, @mtosi, @namapane, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @tsusa, @tvami, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-12-11T19:15:41Z

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43390/summary.html
COMMIT: 53a0974
CMSSW: CMSSW_15_0_X_2024-12-11-0800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46916/43390/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 123 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3623082
DQMHistoTests: Total failures: 2766
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3620296
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-12-11T23:02:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46916/42980

There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Add {Copy,Move}ToDeviceCache<T> class templates and moveToDeviceAsync function template #43969
- File RecoLocalCalo/HGCalRecProducers/plugins/alpaka/HGCalLayerClustersSoAAlgoWrapper.dev.cc modified in PR(s): ALPAKA CLUE2D Code Heterogenous Code Porting #46786
- File RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterECLCC.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632
- File RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterSoAProducerKernel.dev.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632

cmsbuild · 2024-12-11T23:03:06Z

Pull request #46916 was updated. @Moanwar, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2024-12-18T22:30:26Z

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43559/summary.html
COMMIT: 51f1595
CMSSW: CMSSW_15_0_X_2024-12-18-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46916/43559/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/RecoLocalCalo/HcalRecProducers/plugins/RecoLocalCaloHcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHcalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/RecoLocalTracker/SiPixelClusterizer/plugins/RecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1884: tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/SiPixelClusterSoA/test/Clusters_testROCmAsync/libClusters_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/SiPixelDigiSoA/test/DigiErrors_testROCmAsync/libDigiErrors_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/TrackingRecHitSoA/test/Hits_testROCmAsync/libHits_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/VertexSoA/test/ZVertexSoA_testROCmAsync/libZVertexSoA_testROCmAsync_rocm.a to productstore area:

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoLocalTracker/SiPixelRecHits
>> Entering Package RecoParticleFlow/PFClusterProducer
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Entering Package RecoTracker/PixelSeeding
>> Compile sequence completed for CMSSW CMSSW_15_0_X_2024-12-18-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
Command exited with non-zero status 1
	Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes"
	User time (seconds): 5655.37
	System time (seconds): 568.06
	Percent of CPU this job got: 927%

fwyzard · 2025-01-15T15:37:47Z

Rebased to fix the conflict, and checked that it builds on top of CMSSW_15_0_X_2025-01-15-1100.

fwyzard · 2025-01-15T15:37:54Z

enable gpu

fwyzard · 2025-01-15T15:37:58Z

please test

cmsbuild · 2025-01-15T15:41:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46916/43304

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): Replace ALPAKA_STATIC_ACC_MEM_GLOBAL with HOST_DEVICE_CONSTANT #47108
- File RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterSoAProducerKernel.dev.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632
- File RecoTracker/PixelSeeding/plugins/alpaka/BrokenLineFit.dev.cc modified in PR(s): CA Extension to strips #47090
- File RecoTracker/PixelSeeding/plugins/alpaka/CACell.h modified in PR(s): CA Extension to strips #47090
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.dev.cc modified in PR(s): CA Extension to strips #47090
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): CA Extension to strips #47090
- File RecoTracker/PixelSeeding/plugins/alpaka/CAPixelDoubletsAlgos.h modified in PR(s): CA Extension to strips #47090
- File RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc modified in PR(s): CA Extension to strips #47090

cmsbuild · 2025-01-15T15:41:28Z

Pull request #46916 was updated. @Moanwar, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2025-01-15T16:14:10Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 476KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43774/summary.html
COMMIT: 3425e81
CMSSW: CMSSW_15_0_X_2025-01-15-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46916/43774/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Run3-hcx381 Provide a test code to provide # of readout cells for the calorimeters #47096

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43774/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43774/git-merge-result

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoLocalTracker/SiPixelRecHits
>> Entering Package RecoParticleFlow/PFClusterProducer
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Entering Package RecoTracker/PixelSeeding
>> Compile sequence completed for CMSSW CMSSW_15_0_X_2025-01-15-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
Command exited with non-zero status 1
	Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes"
	User time (seconds): 5799.50
	System time (seconds): 585.33
	Percent of CPU this job got: 959%

cmsbuild added this to the CMSSW_15_0_X milestone Dec 11, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started upgrade-pending code-checks-pending heterogeneous-pending tracking trk labels Dec 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 11, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 11, 2024

makortel mentioned this pull request Dec 11, 2024

Investigate moving alpaka device code to .dev.cc files #44625

Open

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Dec 11, 2024

fwyzard force-pushed the replace_TAcc_with_explicit_accelerator_type branch from a8c4272 to 79efc01 Compare December 11, 2024 22:59

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 11, 2024

fwyzard force-pushed the replace_TAcc_with_explicit_accelerator_type branch from 79efc01 to 51f1595 Compare December 11, 2024 23:10

cmsbuild added tests-rejected and removed tests-started labels Dec 18, 2024

This was referenced Jan 7, 2025

Replace configuration-copying Alpaka ESProducers with MoveToDeviceCache #47047

Merged

CA Extension to strips #47090

Draft

cmsbuild mentioned this pull request Jan 15, 2025

Replace ALPAKA_STATIC_ACC_MEM_GLOBAL with HOST_DEVICE_CONSTANT #47108

Merged

fwyzard added 7 commits January 15, 2025 16:37

Replace TAcc with the explicit accelerator type

18e373b

Replace TAcc with the explicit accelerator type

5dcff99

Replace TAcc with the explicit accelerator type

d75e76e

Replace TAcc with the explicit accelerator type

167540f

Replace TAcc with the explicit accelerator type

d7d4fb3

Replace TAcc with the explicit accelerator type

dc851f8

Replace TAcc with the explicit accelerator type

3425e81

fwyzard force-pushed the replace_TAcc_with_explicit_accelerator_type branch from 51f1595 to 3425e81 Compare January 15, 2025 15:37

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 15, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 15, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `TAcc` with explicit accelerator type #46916

Replace `TAcc` with explicit accelerator type #46916

fwyzard commented Dec 11, 2024

fwyzard commented Dec 11, 2024

cmsbuild commented Dec 11, 2024 •

edited

Loading

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 18, 2024

fwyzard commented Jan 15, 2025

fwyzard commented Jan 15, 2025

fwyzard commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

Replace TAcc with explicit accelerator type #46916

Are you sure you want to change the base?

Replace TAcc with explicit accelerator type #46916

Conversation

fwyzard commented Dec 11, 2024

PR description:

PR validation:

fwyzard commented Dec 11, 2024

cmsbuild commented Dec 11, 2024 • edited Loading

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

Comparison Summary

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 11, 2024

cmsbuild commented Dec 18, 2024

Build

Clang Build

fwyzard commented Jan 15, 2025

fwyzard commented Jan 15, 2025

fwyzard commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

cmsbuild commented Jan 15, 2025

Clang Build

Replace `TAcc` with explicit accelerator type #46916

Replace `TAcc` with explicit accelerator type #46916

cmsbuild commented Dec 11, 2024 •

edited

Loading