-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a compilation warning in TracksterLinkingbySkeletons in DBG_X #45999
Conversation
cms-bot internal usage |
please test for CMSSW_14_2_DBG_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45999/41772 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
fixes #45998 |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test test_dumpRecoGeometry had ERRORS Comparison SummarySummary:
|
The unit test failure
looks like it was killed because of running too long. @smuzaffar do you agree? Maybe this test should be split into a few in order to run the (sub)tests in parallel? |
@cmsbuild, please test Let's try again. |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
Not sure if the test is OK, bot complains about some unit test was failed |
yes @makortel , this unit tests takes over an hour for |
ignore tests-rejected with ib-failure unit test failure for |
I opened an issue #46053 |
+1 |
@cms-sw/upgrade-l2 Could you review and sign? Thanks! |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes #45998
Resolves cms-sw/framework-team#1022
PR validation:
None