Fix pointers double deletions from PoolDBOutputService in CondTools subsystem

[mmusich]

resolves #35723 and #35670

PR description:

PR #35048 changed the behaviour of payload pointer ownership for condition updating workflows.
In a couple of workflows tested in unit tests (CondTools/BeamSpot and CondTools/SiPhase2Tracker) the raw pointer underlying a std::unique_ptr to the payload to be written was passed to the createNewIOV and writeOne methods of PoolDBOutputService that are now deleting the pointer. This might lead to double deletion and consequent job crashes.
In this PR (commit d68381f) the behaviour is changed by releasing the ownership of the managed payload object to the PoolDBOutputService hence avoiding the double deletion.
I profit of this PR to introduce (in commit aef5077) a new plugin SiPhase2OuterTrackerLorentzAngleReader to read SiPhase2OuterTrackerLorentzAngle payloads and use it in unit tests.

PR validation:

Run the augmented unit tests scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35731/26056

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35731/26056/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35731/26056/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35731/26057

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/BeamSpot (db, alca)
• CondTools/SiPhase2Tracker (upgrade, alca)

@malbouis, @yuanchao, @cmsbuild, @AdrianoDee, @srimanob, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[tvami]

@cmsbuild , ping

[cmsbuild]

Pull request #35731 was updated. @malbouis, @yuanchao, @cmsbuild, @AdrianoDee, @srimanob, @ggovi, @tvami, @francescobrivio can you please check and sign again.

[perrotta]

please test

[mmusich]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21ba7/19740/summary.html
COMMIT: 419cab1
CMSSW: CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35731/19740/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751090
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass nicely, only MsgLogger diff
• no SA errors/warnings
• unit test looks fine
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21ba7/19740/unitTests/src/CondTools/SiPhase2Tracker/test/test_CondToolsSiPhase2Tracker/testing.log

[tvami]

+db

[perrotta]

@cms-sw/upgrade-l2 this fixes a couple of unit tests now broken in the IB: can you please review, and sign if you think so?

[srimanob]

+Upgrade

For the upgrade part, CondTools/SiPhase2Tracker plugins are introduced/updated. They are used in the unit test. The test runs fine.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1