Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] MTD geometry and reconstruction: synchronise with master up to PR 33762 #33795

Merged
merged 1 commit into from
May 24, 2021

Conversation

fabiocos
Copy link
Contributor

…se with master up to PR 33762""

This reverts commit f5281cb, restoring PR cms-sw#33779
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_11_3_X.

It involves the following packages:

Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
RecoMTD/DetLayers
SimFastTiming/FastTimingCommon
Validation/MtdValidation

@perrotta, @civanch, @Dr15Jones, @ahmad3213, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @makortel, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-sw/cmsdist#6928

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b24279/15205/summary.html
COMMIT: c3d4aef
CMSSW: CMSSW_11_3_X_2021-05-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33795/15205/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b24279/15205/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b24279/15205/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cvuosalo
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented May 20, 2021

+1

@srimanob
Copy link
Contributor

backport

@jpata
Copy link
Contributor

jpata commented May 24, 2021

+reconstruction

  • no issues from the reco side with the backport (contains only the needed changes)
  • no modifier protections are applied for a backport of MTD/Phase2 (none are needed)

@srimanob
Copy link
Contributor

+Upgrade

This backport needs cms-sw/cmsdist#6928

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 24, 2021

+1

@cmsbuild cmsbuild merged commit c780471 into cms-sw:CMSSW_11_3_X May 24, 2021
@fabiocos fabiocos deleted the fc-bpMTDto113X branch May 28, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants