Remove a deprecated "Timing" parameter from SiPixelDigiToRaw (and some header cleaning)

[perrotta]

PR description:

Follow up of #33626 (@czangela @mmusich )
"Timing" parameter was deprecated in SiPixelDigiToRaw.cc, and never used anywhere: it is therefore removed from the ones listed in the fillDescriptions method
Some cleaning/reordering of the included headers is also applied.

PR validation:

It builds
Basic workflows run

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33722/22650

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

EventFilter/SiPixelRawToDigi

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@OzAmram, @makortel, @VinInn, @Martin-Grunewald, @dkotlins, @ferencek, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b78291/15061/summary.html
COMMIT: be5b0d9
CMSSW: CMSSW_12_0_X_2021-05-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33722/15061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1268 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 3680
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2644520
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.699 KiB( 36 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline.
You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in
the results of the comparisons

What above explains :

• No significant changes to the logs found
• Reco comparison results: 1268 differences found in the comparisons

Only (relevant) differences are in wf 140.53

[perrotta]

+1

• Trivial code cleaning
• Jenkins tests pass and show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[Martin-Grunewald]

This will break as #33720 is also integrated!
Ah never mind, I confused it with SiPixelRawToDigi...

[mmusich]

This will break as #33720 is also integrated!

why? I hope we're not running digi2raw (packer) in the HLT!

[Martin-Grunewald]

Indeed should be fine!