EtaBToJpsiJpsi gen fragment at 14 TeV for release validation #33386

vjmastra · 2021-04-09T15:05:19Z

PR description:

EtaB to JpsiJpsi to 4muon gen fragment for release validation
targeting BPH multi-lepton trigger paths, not covered for the time being.
The etaB is modeled with a BSM H0 (as done in previous versions of the fragment)

PR validation:

The measured filter efficiency on a generated sample of 5k events is 35%

cmsbuild · 2021-04-09T15:12:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33386/21999

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): New_samples (TTbarLepton_14 and QQH1352T_14) added #33324, Patatrack integration - Pixel workflows (12/N) #31854, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2021-04-09T15:12:54Z

A new Pull Request was created by @vjmastra (Vincenzo) for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2021-04-09T15:14:03Z

this will definitely conflict with #33324 (just so everyone is aware)

chayanit · 2021-04-12T04:40:50Z

Is it possible that extra HLT requests come together in the same PR? This is confusing...
@sharmaaash, @vjmastra

srimanob · 2021-04-13T07:06:11Z

Hi @vjmastra
I have to admit that I confuse the goal of this PR. If these GEN fragments are not needed for any workflows in PyReleaseValidation, it should go to https://github.com/cms-sw/genproductions. We should not add something that we don't need to CMSSW. With RelVals machine (not runTheMatrix), PdmV can pick up any configs.

vjmastra · 2021-04-13T07:53:50Z

Hi @vjmastra
I have to admit that I confuse the goal of this PR. If these GEN fragments are not needed for any workflows in PyReleaseValidation, it should go to https://github.com/cms-sw/genproductions. We should not add something that we don't need to CMSSW. With RelVals machine (not runTheMatrix), PdmV can pick up any configs.

Hi @srimanob, the GEN fragment I uploaded is needed for the release validation (as described here https://its.cern.ch/jira/browse/PDMVRELVALS-115).

Hi @chayanit, from the comments on Jira I understand that it is ok to upload the fragment,
while the change (1 line addition) in upgradeWorkflowComponents.py is not.
Do you need me to take action on this or it can be handled by the reviewers?

srimanob · 2021-04-13T08:09:25Z

Ah, my false sorry. You define the fragment in upgradeWorkflowComponents.py also.

Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_14TeV_TuneCP5_cfi.py

srimanob · 2021-04-13T08:12:40Z

My comment is then the filename should not contain "_forSTEAM". It is GEN fragment file that can be used for anything.

agrohsje · 2021-04-13T12:46:42Z

Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_14TeV_TuneCP5_cfi.py

+
+generator.PythiaParameters.processParameters.extend(EvtGenExtraParticles)
+
+etafilter = cms.EDFilter("PythiaFilter",


why is this called etafilter?

I did as in previous version of the fragment available in CMSSW (

cmssw/Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_TuneCUEP8M1_13TeV_cfi.py

Line 44 in 02d443b

etafilter = cms.EDFilter("PythiaFilter",

)

The BSM Higgs (pdgid=35) with mass forced to the same as etaB is used instead of an etaB.
The filter requires its presence.

agrohsje · 2021-04-13T12:47:10Z

Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_14TeV_TuneCP5_cfi.py

+      '443:onMode = off',
+      '443:onIfMatch 13 -13',
+      ############# Fix to mass of etaB (9.4 GeV) #############
+      '35:mMin = 0',


what is the purpose of min and max if you set 0 width ?

I left the properties as in the previous version of the fragment

cmssw/Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_TuneCUEP8M1_13TeV_cfi.py

Line 31 in 02d443b

'35:mMin = 0',

The definition of the mass range should have no effect as width is set to 0

agrohsje · 2021-04-20T09:09:14Z

I have a small comment on the name. If we want to follow the dataset convention it should be TuneCP5_14TeV_pythia8. Sometimes we indicate ptyhia8 in fragments, sometimes not. Clearly having it makes it easier to understand what is hidden in the file. Not sure if filter info should be added. The name includes most of it. No strong opinion.

vjmastra · 2021-04-25T16:26:02Z

I have a small comment on the name. If we want to follow the dataset convention it should be TuneCP5_14TeV_pythia8. Sometimes we indicate ptyhia8 in fragments, sometimes not. Clearly having it makes it easier to understand what is hidden in the file. Not sure if filter info should be added. The name includes most of it. No strong opinion.

I couldn't see this kind of naming under Configuration/Generator/python ...
please let me know how to act on this and if other actions are needed, thanks

agrohsje · 2021-04-28T19:36:38Z

Maybe you can just add _pythia8, so EtaBToJpsiJpsi_14TeV_TuneCP5_pythia8_cfi.py

…neCP5_pythia8_cfi.py

cmsbuild · 2021-04-29T08:08:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33386/22370

This PR adds an extra 28KB to repository
Found files with invalid states:
- Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_14TeV_TuneCP5_cfi.py:
  - Added: 5e8b23b
  - Deleted: 668d046
- Configuration/Generator/python/EtaBToJpsiJpsi_14TeV_TuneCP5_cfi.py:
  - Added: bd779ba
  - Deleted: f804491

cmsbuild · 2021-04-29T08:08:50Z

Pull request #33386 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

agrohsje · 2021-04-29T18:39:35Z

+generators

cmsbuild · 2021-04-29T18:40:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-04-29T21:14:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2201d/14714/summary.html
COMMIT: f804491
CMSSW: CMSSW_12_0_X_2021-04-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33386/14714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662700
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2662675
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

qliphy · 2021-04-30T01:16:17Z

+1

new EtaBToJpsiJpsi fragment at 14 TeV + inclusion in workflow

5e8b23b

cmsbuild added this to the CMSSW_11_3_X milestone Apr 9, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Apr 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2021

cmsbuild mentioned this pull request Apr 10, 2021

New_samples (TTbarLepton_14 and QQH1352T_14) added with some changes #33391

Closed

srimanob reviewed Apr 13, 2021

View reviewed changes

Configuration/Generator/python/EtaBToJpsiJpsi_forSTEAM_14TeV_TuneCP5_cfi.py Outdated Show resolved Hide resolved

agrohsje reviewed Apr 13, 2021

View reviewed changes

vjmastra added 3 commits April 13, 2021 15:34

remove inclusion in workflow to avoid conflict with other PRs

ed36159

rename file (_forSTEAM removed)

bd779ba

remove old file

668d046

cmsbuild added code-checks-pending and removed code-checks-approved pdmv-pending upgrade-pending labels Apr 13, 2021

cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021

This was referenced Apr 19, 2021

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Merged

New_samples (TTbarLepton_14 and QQH1252T_14) added without updating 'upgradeWorkflowComponents' file #33409

Merged

Rename EtaBToJpsiJpsi_14TeV_TuneCP5_cfi.py to EtaBToJpsiJpsi_14TeV_Tu…

f804491

…neCP5_pythia8_cfi.py

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 29, 2021

cmsbuild added fully-signed generators-approved tests-started and removed generators-pending pending-signatures tests-pending labels Apr 29, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 30, 2021

cmsbuild merged commit a550b8b into cms-sw:master Apr 30, 2021

cmsbuild mentioned this pull request Apr 30, 2021

Pixel local reco: reduce code duplication between SiPixelDigiErrorsFromSoA and SiPixelRawToDigi #33526

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EtaBToJpsiJpsi gen fragment at 14 TeV for release validation #33386

EtaBToJpsiJpsi gen fragment at 14 TeV for release validation #33386

vjmastra commented Apr 9, 2021

cmsbuild commented Apr 9, 2021

cmsbuild commented Apr 9, 2021

kpedro88 commented Apr 9, 2021

chayanit commented Apr 12, 2021

srimanob commented Apr 13, 2021

vjmastra commented Apr 13, 2021

srimanob commented Apr 13, 2021

srimanob commented Apr 13, 2021

agrohsje Apr 13, 2021

vjmastra Apr 13, 2021 •

edited

Loading

agrohsje Apr 13, 2021

vjmastra Apr 13, 2021

agrohsje commented Apr 20, 2021 •

edited

Loading

vjmastra commented Apr 25, 2021

agrohsje commented Apr 28, 2021

cmsbuild commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

agrohsje commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

qliphy commented Apr 30, 2021


		generator.PythiaParameters.processParameters.extend(EvtGenExtraParticles)

		etafilter = cms.EDFilter("PythiaFilter",

EtaBToJpsiJpsi gen fragment at 14 TeV for release validation #33386

EtaBToJpsiJpsi gen fragment at 14 TeV for release validation #33386

Conversation

vjmastra commented Apr 9, 2021

PR description:

PR validation:

cmsbuild commented Apr 9, 2021

cmsbuild commented Apr 9, 2021

kpedro88 commented Apr 9, 2021

chayanit commented Apr 12, 2021

srimanob commented Apr 13, 2021

vjmastra commented Apr 13, 2021

srimanob commented Apr 13, 2021

srimanob commented Apr 13, 2021

agrohsje Apr 13, 2021

Choose a reason for hiding this comment

vjmastra Apr 13, 2021 • edited Loading

Choose a reason for hiding this comment

agrohsje Apr 13, 2021

Choose a reason for hiding this comment

vjmastra Apr 13, 2021

Choose a reason for hiding this comment

agrohsje commented Apr 20, 2021 • edited Loading

vjmastra commented Apr 25, 2021

agrohsje commented Apr 28, 2021

cmsbuild commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

agrohsje commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

cmsbuild commented Apr 29, 2021

Comparison Summary

qliphy commented Apr 30, 2021

vjmastra Apr 13, 2021 •

edited

Loading

agrohsje commented Apr 20, 2021 •

edited

Loading