-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeamSpot clients cleanup #33284
BeamSpot clients cleanup #33284
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33284/21792
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages: DQM/Integration @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84d1df/13809/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Cleanup of the BeamSpot clients:
lastLumiUrl
parameter which was removed in Condition DB modules for HLT workflow: clean up old lumi information source from DAQ #32885lastLumiFile
parameter where not neededomsServiceUrl
parameter in case the clients are run in the DQM replayPR validation:
Code compiles and passes unit tests.
The changes in this PR were already tested at P5 and in the DQM replay system as reported in #32929
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport, but it will be backported to 11_2_X so it can be picked up in next MWGR
FYI @gennai @ggovi