GPU pixel local reconstruction: make the pixel cluster thresholds configurable #33259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33259/21742
|
|
A new Pull Request was created by @czangela for master. It involves the following packages: RecoLocalTracker/SiPixelClusterizer @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
VinInn
reviewed
Mar 24, 2021
RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterThresholds.h
Outdated
Show resolved
Hide resolved
davidlange6
reviewed
Mar 24, 2021
RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterThresholds.h
Outdated
Show resolved
Hide resolved
VinInn
reviewed
Mar 24, 2021
RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterThresholds.h
Outdated
Show resolved
Hide resolved
VinInn
reviewed
Mar 24, 2021
RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterCUDA.cc
Outdated
Show resolved
Hide resolved
|
On Mar 24, 2021, at 5:01 PM, Vincenzo Innocente ***@***.***> wrote:
@VinInn commented on this pull request.
In RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterThresholds.h:
> @@ -0,0 +1,11 @@
+#ifndef RecoLocalTracker_SiPixelClusterizer_plugins_gpuClusterThresholds_h
why?
Its used somewhere other than this directory
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
In practice we allow header-only code from |
|
Ok - I didn’t realize. Thx
… On Mar 24, 2021, at 5:08 PM, Matti Kortelainen ***@***.***> wrote:
why?
Its used somewhere other than this directory
In practice we allow header-only code from plugins to be included in test of the same package.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33259/21744 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33259/21745
|
mmusich
reviewed
Apr 6, 2021
RecoLocalTracker/Phase2TrackerRecHits/plugins/Phase2TrackerRecHits.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/interface/PixelClusterSelectorTopBottom.h
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/HITrackClusterRemover.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/HLTTrackClusterRemoverNew.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/JetCoreClusterSplitter.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/PixelClusterSelectorTopBottom.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/SeedClusterRemover.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/SeedClusterRemoverPhase2.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SubCollectionProducers/src/StripClusterSelectorTopBottom.cc
Outdated
Show resolved
Hide resolved
…sFromSoA.cc Make cluster charge cut thresholds configurable for the function gpuClusterChargeCut Add inline function for threshold choosing change local includes, use phase1PixelTopology constant
czangela
force-pushed
the
pixel_local_reco_refactorings_issue2_22_03_2021
branch
from
566baed to
822c264
Compare
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
upgrade-pending
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33259/21899
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca299/14009/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Validation plots/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAWThroughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This is an effort towards solving one of the issues in #32483.
Hardcoded charge cuts on pixel clusters were used in:
RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.handRecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.ccSince the GPU version uses these thresholds in the free function
gpuClusterChargeCutnested in thegpuClusteringnamespace, they are propagated through function parameters, passing them by value. They are initially set in theSiPixelRawToClusterCUDAclass.The
SiPixelDigisClustersFromSoAhas these parameters as private members (as does the legacy version).PR validation:
These changes should not affect validation results.
Performance should not be affected.
if this PR is a backport please specify the original PR and why you need to backport that PR: