-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Migration to DD4Hep for CSC and RPC db Loader #32992
Update Migration to DD4Hep for CSC and RPC db Loader #32992
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32992/21256
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: CondTools/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @ggovi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d59527/13079/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
1 similar comment
+1 |
PR description:
This PR (only for CSC and RPC) is an update what I did in the PRs #32102 #32001.
PR validation:
Validation by using a dump scripts (for DDD and DD4HEP) related to CSC and RPC, not included in this PR (because they use local .mb files). Details are present in [*] at the end of this PR description.
The command used is "cmsRun dumpCSCGeometry_DB_cfg.py" (the same for RPC).
// DDD (CSC)
(0) CSCGeometryESModule - DB recreateGeometry=true
CSCGeometry found with 612 chambers
Chamber 0:2:ME1/b: (E:1 S:1 R:1 C:1 L:0) with 6 layers
Layer 0:CSC: (E:1 S:1 R:1 C:1 L:1)
Layer 1:CSC: (E:1 S:1 R:1 C:1 L:2)
Layer 2:CSC: (E:1 S:1 R:1 C:1 L:3)
Layer 3:CSC: (E:1 S:1 R:1 C:1 L:4)
Layer 4:CSC: (E:1 S:1 R:1 C:1 L:5)
Layer 5:CSC: (E:1 S:1 R:1 C:1 L:6)
and so on.
// DD4HEP (CSC)
(0) CSCGeometryESModule - DB recreateGeometry=true
CSCGeometry found with 612 chambers
Chamber 0:2:ME1/b: (E:1 S:1 R:1 C:1 L:0) with 6 layers
Layer 0:CSC: (E:1 S:1 R:1 C:1 L:1)
Layer 1:CSC: (E:1 S:1 R:1 C:1 L:2)
Layer 2:CSC: (E:1 S:1 R:1 C:1 L:3)
Layer 3:CSC: (E:1 S:1 R:1 C:1 L:4)
Layer 4:CSC: (E:1 S:1 R:1 C:1 L:5)
Layer 5:CSC: (E:1 S:1 R:1 C:1 L:6)
and so on.
// DDD (RPC)
(0) RPCGeometryESModule - DB
RPCGeometry found with 1056 chambers
Chamber 0: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 0 Tr 0 with 3 rolls
Roll 0: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 1 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 2.37878
Roll 1: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 2 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 2.09312
Roll 2: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 3 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 1.73672
and so on.
// DD4Hep (RPC)
(0) RPCGeometryESModule - DB
RPCGeometry found with 1056 chambers
Chamber 0: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 0 Tr 0 with 3 rolls
Roll 0: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 1 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 2.37878
Roll 1: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 2 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 2.09312
Roll 2: Re -1 Ri 2 St 1 Se 1 La 1 Su 1 Ro 3 Tr 0 Barrel|Endcap 0:1:0 with 32 of pitch 1.73672
and so on.
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special
[*]
In CMSSW_11_3_X_2021-02-15-1100 (for DDD) and CMSSW_11_3_X_2021-02-15-2300 (for DD4Hep)
a) In /condTools/Geom/test
cp writehelp/* .
b) ./createExtended2021Payload.sh 113YV8 (for DDD and 113YV9 for DD4Hep)
Then I created a
script called "dumpCSCGeometry_DB_cfg.py" (the same for RPC) and the lines are:
+++++++
import FWCore.ParameterSet.Config as cms
process = cms.Process('DUMP')
process.load("CondCore.CondDB.CondDB_cfi")
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.load("Geometry.MuonNumbering.muonGeometryConstants_cff")
process.load("Geometry.CSCGeometryBuilder.cscGeometryDB_cfi")
process.load("Geometry.CSCGeometryBuilder.cscGeometryDump_cfi")
process.MessageLogger = cms.Service("MessageLogger",
destinations = cms.untracked.vstring('myLogCSC'),
myLogCSC = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
)
)
process.muonGeometryConstants.fromDD4Hep = True
process.CSCGeometryESModule.applyAlignment = False
from Configuration.AlCa.autoCond import autoCond
process.GlobalTag.globaltag = autoCond['mc']
process.GlobalTag.toGet = cms.VPSet(cms.PSet(record = cms.string('CSCRecoGeometryRcd'),
tag = cms.string('CSCRECO_Geometry_113YV9'),
connect = cms.string("sqlite_file:/afs/cern.ch/user/s/slomeo/CMSSW_11_3_X_2021-02-15-1100/src/CondTools/Geometry/test/myfile.db")))
process.source = cms.Source('EmptySource')
process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(1)
)
process.p = cms.Path(process.gemGeometryDump)
++++++++++++