Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for coral MessageService wrapper #32503

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Bug fix for coral MessageService wrapper #32503

merged 2 commits into from
Dec 17, 2020

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Dec 16, 2020

PR description:

This pr addresses #31896

The fixes involve a wrapper for the Coral message Reporter:

  • complying with expected pointer ownership in coral
  • ensuring better hand-shake while de-scoping objects

PR validation:

CondDB Unit test, integration test with BeamSpot client ( including the recipe for reproducing the above issue )

@ggovi ggovi mentioned this pull request Dec 16, 2020
Closed
@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Dec 16, 2020
@jfernan2
Copy link
Contributor

Dear @ggovi
Could we have a backport of this PR to 11_2_X in order to use it at P5 during next MWGR?
Thanks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32503/20435

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/CondDB
CondCore/DBOutputService

@yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Dec 16, 2020

please test

@makortel makortel mentioned this pull request Dec 16, 2020
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d5f0f/11747/summary.html
CMSSW: CMSSW_11_3_X_2020-12-16-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747311
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2747282
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

christopheralanwest
christopheralanwest reviewed Dec 16, 2020
View reviewed changes
CondCore/CondDB/src/ConnectionPool.cc Outdated
@@ -23,6 +23,9 @@ namespace cond {

ConnectionPool::ConnectionPool() {
m_pluginManager = new cond::CoralServiceManager;
m_msgReporter = new CoralMsgReporter;
// ownership is acquired ( instrinsically unsafe, need to change coral )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you correct the spelling of "intrinsically"?

@ggovi
Copy link
Contributor Author

ggovi commented Dec 17, 2020

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32503/20459

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32503 was updated. @ggovi, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

@ggovi
Copy link
Contributor Author

ggovi commented Dec 17, 2020

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d5f0f/11760/summary.html
CMSSW: CMSSW_11_3_X_2020-12-16-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747311
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2747282
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Dec 17, 2020

+1

@christopheralanwest
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@cms-sw/core-l2 the ASAN IB should look much better after this PR

@cmsbuild cmsbuild merged commit 8a23c45 into cms-sw:master Dec 17, 2020
@ggovi ggovi mentioned this pull request Dec 22, 2020
Merged
@francescobrivio francescobrivio mentioned this pull request Nov 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopheralanwest christopheralanwest christopheralanwest left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@ggovi @jfernan2 @cmsbuild @christopheralanwest @silviodonato