Trivial update to PFClusterFromHGCalMultiCluster.cc

[perrotta]

Check if the multicluster is empty and move to the next one before having to compute the trackster PID, as it was implemented in the 11_1 "backport" PR #31907 (it avoids computing the probabilities when not needed)

@rovere @felicepantaleo, this is what I meant in the last paragraph of my comment #31907 (comment): just let me know if you have anything in contrary

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32236/19988

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @clelange, @lecriste, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-22-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10925/console Started: 2020/11/22 14:04

[cmsbuild]

+1
Tested at: 3bb3cc9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce5a0d/10925/summary.html
CMSSW: CMSSW_11_2_X_2020-11-22-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[rovere]

Thanks, @perrotta I also agree this is somewhat cleaner and, possibly, more efficient.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce5a0d/10925/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2961011
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2960976
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[perrotta]

+1

• Only switched two sets of instructions, so that the most expensive check can be avoided in case the mulicluster is found empty
• Jenkins tests pass and show no differences, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

assign upgrade
(simple PR, but it is related to HGCal...)

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1