Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #30306, #31591, and #31973: NanoGen support in 10_6_X #31909

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Backport of #30306, #31591, and #31973: NanoGen support in 10_6_X #31909

merged 6 commits into from
Nov 4, 2020

Conversation

kdlong
Copy link
Contributor

@kdlong kdlong commented Oct 22, 2020 •
edited
Loading

PR description:

Backport of #30306, #31591, and #31973 in order to have NanoGen support in the release version where UL GEN and NANOAOD are being produced

PR validation:

NanoGen workflows run, also tested some private samples.

kdlong added 3 commits October 22, 2020 15:15
@kdlong
Add NanoGen configs
79c92f1 
Fix NanoGEN weights tables, work from MinAOD

No cuts on dressed leptons for nanogen

Add customize functions

Simplify NanoGEN from Mini workflow

Run NanoGen from runTheMatrix.py

Add DQM support, improve nanogen configs

Clean up output, remove trigger branches

Revert accidental change

Add nanogenDQM file

A few more NanoGen DQM plots, update default precision

Add lhe and weights plots to main nano dqm

Update generator configs

Minimize changes to nanoDQM

fix duplicates
@kdlong
Fix issue with cmsDriver from cherry-pick
6a9fd08
@kdlong
Add genWeights table, fix dqm
b11d496
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Oct 22, 2020
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kdlong (Kenneth Long) for CMSSW_10_6_X.

It involves the following packages:

Configuration/Applications
Configuration/Generator
Configuration/PyReleaseValidation
DQMOffline/Configuration
PhysicsTools/NanoAOD

@SiewYan, @andrius-k, @gouskos, @chayanit, @wajidalikhan, @kpedro88, @fioriNTU, @alberto-sanchez, @santocch, @silviodonato, @ErnestaP, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @davidlange6, @jfernan2, @qliphy, @fabiocos, @mkirsano, @jordan-martins, @kmaeshima, @franzoni, @fgolf, @mariadalfonso can you please review it and eventually sign? Thanks.
@swertz, @makortel, @fabiocos, @Martin-Grunewald, @gpetruc, @threus, @peruzzim, @slomeo, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@mariadalfonso mariadalfonso mentioned this pull request Oct 22, 2020
Closed
55 tasks
@cmsbuild
Copy link
Contributor

+1
Tested at: b11d496
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865db8/10220/summary.html
CMSSW: CMSSW_10_6_X_2020-10-22-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865db8/10220/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214663
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214326
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.987 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 5.987 KiB Physics/NanoAODDQM
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@chayanit
Copy link

+1

@mariadalfonso
Copy link
Contributor

+xpog
nanoGEN : completed backport to 10_6 inline with changes in master

@chayanit
Copy link

+1

@SiewYan
Copy link
Contributor

SiewYan commented Oct 30, 2020

+1

@jfernan2
Copy link
Contributor

+1

@mariadalfonso
Copy link
Contributor

@kpedro88 any request on this PR ?

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 3, 2020

+upgrade

@santocch
Copy link

santocch commented Nov 4, 2020

+1

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ff93e45 into cms-sw:CMSSW_10_6_X Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariadalfonso mariadalfonso mariadalfonso left review comments

Assignees
No one assigned
Labels
analysis-approved comparison-available dqm-approved fully-signed generators-approved operations-approved orp-approved pdmv-approved tests-approved upgrade-approved xpog-approved
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.
9 participants
@kdlong @cmsbuild @kpedro88 @chayanit @jfernan2 @santocch @SiewYan @mariadalfonso @silviodonato