Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: add scenarios D72 (ETL v4) and D73 (ETL v5), remove D53 #31710

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Oct 8, 2020

PR description:

This PR is based on the recent refresh of phase2 scenarios in #31673 , updates the ETL TDR scenario v4, moving it from D53 (which is removed) to D72, and adds the post-TDR ETL scenario v5, where only two sectors per disc are used. With the occasion, the association Left / Right to type 1 / 2 modules is inverted, for practical purposes of geometrical ordering to be used in the RecoMTD/DetLayers tracking geometry.

Test workflows are provided, but not added to the matrix until the update of RecoMTD/DetLayers is made (otherwise the RECO step is bound to fail).

For the time being the Phase2C11 era is used, as in scenario D68, which is the starting point for the new ones here added. Anyway the possible addition of an ETL-dedicated modifier, as discussed in the scrutiny of #31654 , should be refrected in the update of this PR.

PR validation:

All the standalone tests of MTD geometry packages produce reports that are consistent with the drawings upon direct inspection, and existing unit tests (based on D50) are not affected. These scenarios are currently used to develop the update of RecoMTD/DetLayers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The code-checks are being triggered in jenkins.

@fabiocos fabiocos changed the title MTD geometry: add scenarios D72 (ETL v4) and D73 (ETL (v5), remove D53 MTD geometry: add scenarios D72 (ETL v4) and D73 (ETL v5), remove D53 Oct 8, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31710/18884

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/MTDCommonData

@civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 8, 2020

@icosivi your recent updates are here

@casarsa @gsorrentino18 @kpedro88 @slava77 if we want to add a modifier to account for the ETL evolution, it should enter first of all here in the definition of the scenarios, on top of the Phase2C11 era

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+1
Tested at: 0fb4d21
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-552ab8/9804/summary.html
CMSSW: CMSSW_11_2_X_2020-10-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-552ab8/9804/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-552ab8/28234.0_TTbar_14TeV+2026D64+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2453937
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2453908
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@cvuosalo
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@kpedro88 @cvuosalo this PR is now fully embedded in #31765, as soon as it is integrated I will rebase that
@chayanit here I just define new workflows, in #31765 I add them to the matrix for possible use in tests

@bsunanda
Copy link
Contributor

@fabiocos @kpedro88 which version of MTD geometry is compatible with C14 and O7?

@fabiocos
Copy link
Contributor Author

@bsunanda the new MTD versions I12 and I13 should be equivalent from the HGCal point of view, they are the TDR/post TDR designs as implemented in the drawings discussed with you, N. Koss and @icosivi . From the description in the README I understand that as far as the ETL mother volumes are concerned C12, C13 and C14 are equivalent to C11, am I correct?

Please take note that until #31765 is integrated, these new MTD scenario cannot have a fully functional workflow (the tracking will fail).

@fabiocos
Copy link
Contributor Author

@chayanit any comment or objection to move forward?

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 05c82a3 into cms-sw:master Oct 16, 2020
@fabiocos fabiocos deleted the fc-etl-v5 branch October 21, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants