-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: add scenarios D72 (ETL v4) and D73 (ETL v5), remove D53 #31710
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31710/18884
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@icosivi your recent updates are here @casarsa @gsorrentino18 @kpedro88 @slava77 if we want to add a modifier to account for the ETL evolution, it should enter first of all here in the definition of the scenarios, on top of the Phase2C11 era |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+upgrade |
+1 |
@bsunanda the new MTD versions I12 and I13 should be equivalent from the HGCal point of view, they are the TDR/post TDR designs as implemented in the drawings discussed with you, N. Koss and @icosivi . From the description in the README I understand that as far as the ETL mother volumes are concerned C12, C13 and C14 are equivalent to C11, am I correct? Please take note that until #31765 is integrated, these new MTD scenario cannot have a fully functional workflow (the tracking will fail). |
@chayanit any comment or objection to move forward? |
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is based on the recent refresh of phase2 scenarios in #31673 , updates the ETL TDR scenario v4, moving it from D53 (which is removed) to D72, and adds the post-TDR ETL scenario v5, where only two sectors per disc are used. With the occasion, the association Left / Right to type 1 / 2 modules is inverted, for practical purposes of geometrical ordering to be used in the
RecoMTD/DetLayers
tracking geometry.Test workflows are provided, but not added to the matrix until the update of
RecoMTD/DetLayers
is made (otherwise the RECO step is bound to fail).For the time being the Phase2C11 era is used, as in scenario D68, which is the starting point for the new ones here added. Anyway the possible addition of an ETL-dedicated modifier, as discussed in the scrutiny of #31654 , should be refrected in the update of this PR.
PR validation:
All the standalone tests of MTD geometry packages produce reports that are consistent with the drawings upon direct inspection, and existing unit tests (based on D50) are not affected. These scenarios are currently used to develop the update of
RecoMTD/DetLayers
.