Remove option to run on single GEM pads; Simplify CSC trigger configuration

[dildick]

PR description:

• First major part: The GEM-CSC trigger will use clusters in Run-3 (not single GEM pads) which will be sent to the ME1/1 optical trigger motherboards over 9.6 Gb/s optical fibers as explained in DN-20-016. This PR finally removes the option to run on single pads (which was the normal way since CMSSW_6_2_X_SLHC).
• Second major part of the pull request is a working version of Clean-up CSC trigger configuration for Run-3 and Phase-2 #31401, with the intent of making the CSC trigger configuration easier to understand. All psets for ALCT, CLCT, TMB, MPC and CCLUT are put in python/params rather than directly in cscTriggerPrimitiveDigis_cfi, reducing the main configuration to less than 100 lines. Thus params/ contains

python/params/
* alctParams_cfi
* clctParams_cfi
* tmbParams_cfi
* auxiliaryParams_cfi
* cclutParams_cfi
* __init__.py

• SLHC was renamed to Phase2 everwhere
• alctClctOffset_ was made a constant, defined in CSCConstants.h
• use_run3_patterns_ and use_comparator_codes_ were merged into runCCLUT_ (because we will not run the Run-3 patterns without CCLUT)

PR validation:

Code compiles. Rebase from #31460 which was stuck in failing code-checks. Performance plots can be found in the #31460 conversation.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31631/18703

• This PR adds an extra 116KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/README.md modified in PR(s): Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549
  • File L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py modified in PR(s): Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549
  • File L1Trigger/CSCTriggerPrimitives/test/macros/CCLUTLinearFitWriter.cpp modified in PR(s): Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/L1TMuon
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[dildick]

All commits squashed into a single commit to get rid of the issue with code-checks.

@silviodonato Can you run the tests, please?

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9666/console Started: 2020/09/30 17:40

[cmsbuild]

The code-checks are being triggered in jenkins.

[silviodonato]

abort

[silviodonato]

code-checks

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89ee3d/10327/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544092
• DQMHistoTests: Total failures: 30
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544040
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[dildick]

@silviodonato This looks good to me now. There are a bit more coincidence pads now, but this is due to the fact that I loosened a window. I did this to increase acceptance for low pT muons and displaced muons.

[silviodonato]

@cms-sw/l1-l2 please review/sign

[silviodonato]

@cms-sw/l1-l2 please review/sign

[rekovic]

Hi @dildick
The change is CSC configuration might lead to changes in the EMTF and EMTF++ performance. Has this been checked? How is EMTF affected, if affected at all.

True that this PR is for 11_2_X, but we should remain consistent with 11_1_X where we are using EMTF for HLT TDR in 11_1_X.

Attn: @jiafulow

[silviodonato]

ping @dildick

[dildick]

@silviodonato Yes, I need to check the effects on the EMTF.

[qliphy]

ping @dildick Do you have any update on EMTF check?

[dildick]

@qliphy I don't see any difference in the Run-3 EMTF trigger efficiency vs pT/eta/phi in this 0 pileup single muon relval sample /RelValSingleMuFlatPt2To100/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW.

[dildick]

@rekovic @qliphy @silviodonato

A few performance plots (not for publication) on 1000 PU200 ecents from dataset /RelValSingleMuFlatPt2To100/CMSSW_11_0_0-PU25ns_110X_mcRun4_realistic_v3_2026D49PU200-v1/GEN-SIM-DIGI-RAW.

First set of plots made with CMSSW_11_2_X_2020-11-23-1100

Second set of plots made with CMSSW_11_2_X_2020-11-23-1100+PR31631

[dildick]

I don't see a noticeable difference in the plots. The EMTF pT efficiency has the same shape (turn-on, plateau).

[qliphy]

ping @cms-sw/l1-l2

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1