changes from review comments and formatting

cms-sw · Jan 16, 2025 · 7b12dde · 7b12dde
1 parent d5db61e
commit 7b12dde
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/FWCore/Framework/src/DroppedDataProductResolver.h b/FWCore/Framework/src/DroppedDataProductResolver.h
@@ -3,9 +3,8 @@
 
 /*----------------------------------------------------------------------
 
-ProductResolver: Class to handle access to a WrapperBase and its related information.
+DroppedDataProductResolver: Handles case of a DataProduct which was dropped on output
 
- [The class was formerly called Group and later ProductHolder]
 ----------------------------------------------------------------------*/
 
 #include "FWCore/Framework/interface/ProductResolverBase.h"
@@ -14,7 +13,7 @@ namespace edm {
   class DroppedDataProductResolver : public ProductResolverBase {
   public:
     DroppedDataProductResolver(std::shared_ptr<BranchDescription const> bd)
-        : ProductResolverBase(), m_provenance(bd, {}) {}
+        : ProductResolverBase(), m_provenance(std::move(bd), {}) {}
 
     void connectTo(ProductResolverBase const&, Principal const*) final {}
 

diff --git a/FWCore/Integration/plugins/TestFindProduct.cc b/FWCore/Integration/plugins/TestFindProduct.cc
@@ -199,15 +199,20 @@ namespace edmtest {
 
     const std::vector<edm::InputTag> emptyTagVector;
 
-    ps.addUntracked<std::vector<edm::InputTag>>("inputTags", emptyTagVector)->setComment("Get these IntProduct data products");
-    ps.addUntracked<int>("expectedSum", 0)->setComment("The sum of all values from data products obtained from entire job.");
+    ps.addUntracked<std::vector<edm::InputTag>>("inputTags", emptyTagVector)
+        ->setComment("Get these IntProduct data products");
+    ps.addUntracked<int>("expectedSum", 0)
+        ->setComment("The sum of all values from data products obtained from entire job.");
     ps.addUntracked<int>("expectedCache", 0)->setComment("Check value of ProcessBlock caches.");
     ps.addUntracked<bool>("getByTokenFirst", false)->setComment("Call getByToken before calling getByLabel");
     ps.addUntracked<bool>("runProducerParameterCheck", false);
     ps.addUntracked<bool>("testGetterOfProducts", false);
-    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsNotFound", emptyTagVector)->setComment("Data products which should be missing from the job.");
-    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsView", emptyTagVector)->setComment("Data products to get via View<int>.");
-    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsUInt64", emptyTagVector)->setComment("Get these UInt64Product data products.");
+    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsNotFound", emptyTagVector)
+        ->setComment("Data products which should be missing from the job.");
+    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsView", emptyTagVector)
+        ->setComment("Data products to get via View<int>.");
+    ps.addUntracked<std::vector<edm::InputTag>>("inputTagsUInt64", emptyTagVector)
+        ->setComment("Get these UInt64Product data products.");
     ps.addUntracked<std::vector<edm::InputTag>>("inputTagsEndLumi", emptyTagVector);
     ps.addUntracked<std::vector<edm::InputTag>>("inputTagsEndRun", emptyTagVector);
     ps.addUntracked<std::vector<edm::InputTag>>("inputTagsBeginProcessBlock", emptyTagVector);