-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROOT632] Updated root to tip of branch v6-32-00-patches #9369
[ROOT632] Updated root to tip of branch v6-32-00-patches #9369
Conversation
please test |
A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/root632. @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
-1 Failed Tests: Build BuildI found compilation error when building: >> Checking EDM Class Transients in libAnalysisDataFormatsTopObjects.so >> Skipped running EDM Class Version test @@@@ ----> OK EDM Class Version @@@@ ----> OK EDM Class Transients >> Checking EDM Class Transients in libAnalysisDataFormatsTrackInfo.so gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libPhysicsToolsPatUtils.so] Error 1 >> Checking EDM Class Version for src/CUDADataFormats/BeamSpot/src/classes_def.xml in libCUDADataFormatsBeamSpot.so >> Skipped running EDM Class Version test >> Checking EDM Class Version for src/CUDADataFormats/CaloCommon/src/classes_def.xml in libCUDADataFormatsCaloCommon.so @@@@ ----> OK EDM Class Version >> Checking EDM Class Transients in libCUDADataFormatsBeamSpot.so |
test parameters:
|
please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 2 errors in the following unit tests: ---> test TestFWCoreReflectionClassVersionUpdate had ERRORS ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
@iarspider , please update the version in root.spec |
@iarspider , there are some recent change in root 6.32 patches branch, as you have to update the version string, please also get the latest root 6.32 changes |
please test |
Pull request #9369 was updated. |
my bad, forget this, I do not know which branch of root I was looking at |
-1 Failed Tests: UnitTests Unit TestsI found 2 errors in the following unit tests: ---> test TestFWCoreReflectionClassVersionUpdate had ERRORS ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
Always fails when ROOT updates
I guess this is expected? |
+externals yes these failures are expected |
f7e4522
into
cms-sw:IB/CMSSW_14_1_X/root632
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/root632 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Changes: cms-sw/root@648a3d8...5f257f1
Version changed to 6.32.04