Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT632] Updated root to tip of branch v6-32-00-patches #9369

Conversation

iarspider
Copy link
Contributor

Changes: cms-sw/root@648a3d8...5f257f1
Version changed to 6.32.04

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/root632.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d66a4/41011/summary.html
COMMIT: b9a9f5f
CMSSW: CMSSW_14_1_ROOT632_X_2024-08-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9369/41011/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Checking EDM Class Transients in libAnalysisDataFormatsTopObjects.so
>> Skipped running EDM Class Version test
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Transients in libAnalysisDataFormatsTrackInfo.so
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libPhysicsToolsPatUtils.so] Error 1
>> Checking EDM Class Version for src/CUDADataFormats/BeamSpot/src/classes_def.xml in libCUDADataFormatsBeamSpot.so
>> Skipped running EDM Class Version test
>> Checking EDM Class Version for src/CUDADataFormats/CaloCommon/src/classes_def.xml in libCUDADataFormatsCaloCommon.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsBeamSpot.so


@iarspider
Copy link
Contributor Author

iarspider commented Aug 19, 2024

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d66a4/41016/summary.html
COMMIT: b9a9f5f
CMSSW: CMSSW_14_1_ROOT632_X_2024-08-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9369/41016/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d66a4/41016/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d66a4/41016/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

Version changed to 6.32.04

@iarspider , please update the version in root.spec

@smuzaffar
Copy link
Contributor

@iarspider , there are some recent change in root 6.32 patches branch, as you have to update the version string, please also get the latest root 6.32 changes

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9369 was updated.

@smuzaffar
Copy link
Contributor

@iarspider , there are some recent change in root 6.32 patches branch, as you have to update the version string, please also get the latest root 6.32 changes

my bad, forget this, I do not know which branch of root I was looking at

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d66a4/41027/summary.html
COMMIT: fefdaf4
CMSSW: CMSSW_14_1_ROOT632_X_2024-08-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9369/41027/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

iarspider commented Aug 20, 2024

TestIOPoolInputNoParentDictionary

Always fails when ROOT updates

TestFWCoreReflectionClassVersionUpdate

I guess this is expected?

@smuzaffar
Copy link
Contributor

+externals

yes these failures are expected

@smuzaffar smuzaffar merged commit f7e4522 into cms-sw:IB/CMSSW_14_1_X/root632 Aug 20, 2024
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/root632 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants