Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal backport of Alpaka fixes for ROCm 5.3 and later #8839

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Minimal backport of Alpaka fixes for ROCm 5.3 and later #8839

merged 1 commit into from
Dec 20, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 28, 2023 •
edited
Loading

Updates Alpaka with a minimal backport of alpaka-group/alpaka#2197:

ROCm 5.3 and later support asynchronous memory operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2023 •
edited
Loading

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_14_0_X/master.

@smuzaffar, @aandvalenzuela, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2023

please test

@makortel
Copy link
Contributor

Could you add "Alpaka" to the title of the PR?

@fwyzard fwyzard changed the title Minimal backport of fixes for ROCm 5.2 and later Minimal backport of Alpaka fixes for ROCm 5.2 and later Nov 28, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2023

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Nov 28, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697a48/36124/summary.html
COMMIT: ee7e20b
CMSSW: CMSSW_14_0_X_2023-11-28-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8839/36124/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 458 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3367918
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3367892
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

@fwyzard , any specific reason to put it on hold?

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 1, 2023

Yes, unfortunately the Alpaka CI is showing some problems with the fix upstream, that I still have to debug.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 15, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697a48/36515/summary.html
COMMIT: ee7e20b
CMSSW: CMSSW_14_0_X_2023-12-15-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8839/36515/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697a48/36515/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697a48/36515/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 97 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3429858
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3429833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@fwyzard fwyzard force-pushed the IB/CMSSW_14_0_X/master branch from ee7e20b to 5853647 Compare December 16, 2023 11:52
@fwyzard fwyzard changed the title Minimal backport of Alpaka fixes for ROCm 5.2 and later Minimal backport of Alpaka fixes for ROCm 5.3 and later Dec 16, 2023
@cmsbuild
Copy link
Contributor

Pull request #8839 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 16, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 16, 2023

unhold

@cmsbuild cmsbuild removed the hold label Dec 16, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697a48/36529/summary.html
COMMIT: 5853647
CMSSW: CMSSW_14_0_X_2023-12-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8839/36529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1487
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38253
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 20, 2023

@smuzaffar @antoniovilela @rappoccio can you merge this for 14.0.0-pre2 ?

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 1f0296f into cms-sw:IB/CMSSW_14_0_X/master Dec 20, 2023
12 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard fwyzard deleted the IB/CMSSW_14_0_X/master branch December 20, 2023 10:24
@cmsbuild cmsbuild mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @makortel @smuzaffar