Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send stacktraces from unit tests to ES #2421

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

iarspider
Copy link
Contributor

As requested in #2419 (comment)

The := (walrus) operator was introduced in Python 3.8, and on cmssdt, Python version is 3.9.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2025

cms-bot internal usage

@iarspider iarspider force-pushed the sig_dostack_to_es_2 branch from a51bbb2 to 4c99ef2 Compare January 27, 2025 09:14
@iarspider iarspider force-pushed the sig_dostack_to_es_2 branch from 4c99ef2 to db1f51a Compare January 27, 2025 09:14
@cmsbuild
Copy link
Contributor

Pull request #2421 was updated.

- old release cycle did not have explicit `success` message.
- unit tests names do not have space in them
@cmsbuild
Copy link
Contributor

Pull request #2421 was updated.

@smuzaffar smuzaffar merged commit 8552e1f into master Jan 27, 2025
3 of 4 checks passed
@smuzaffar smuzaffar deleted the sig_dostack_to_es_2 branch January 27, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants