Update to the code base from the Patatrack CMSSW release #120

fwyzard · 2020-11-05T14:52:13Z

Highlights:

remove the dependency on the CUB external
reduce caching allocator memory usage
update CUDA to version 11.0 and C++17
update the code base from CMSSW 11.2.x
import more tests from the cuda directory

makortel

Could you also update the README in https://github.com/cms-patatrack/pixeltrack-standalone#cudadev to point to CMSSW_11_2_0_pre8_Patatrack (which I presume to be the version where you picked the code based on the branch name)

makortel · 2020-11-05T15:12:08Z

Makefile

@@ -38,15 +42,13 @@ export CUDA_LDFLAGS := -L$(CUDA_BASE)/lib64 -lcudart -lcudadevrt
 export CUDA_NVCC := $(CUDA_BASE)/bin/nvcc
 define CUFLAGS_template
 $(2)NVCC_FLAGS := $$(foreach ARCH,$(1),-gencode arch=compute_$$(ARCH),code=sm_$$(ARCH)) -Wno-deprecated-gpu-targets -Xcudafe --diag_suppress=esa_on_defaulted_function_ignored --expt-relaxed-constexpr --expt-extended-lambda --generate-line-info --source-in-ptx --cudart=shared
-$(2)NVCC_COMMON := -std=c++14 -O3 $$($(2)NVCC_FLAGS) -ccbin $(CXX) --compiler-options '$(HOST_CXXFLAGS) $(USER_CXXFLAGS)'
+$(2)NVCC_COMMON := -std=c++17 -O3 $$($(2)NVCC_FLAGS) -ccbin $(CXX) --compiler-options '$(HOST_CXXFLAGS) $(USER_CXXFLAGS)'


This would bump the minimum CUDA requirement to 11, right? (ok, I see you updated the README). I need to understand the impact on Kokkos.

Seems that Kokkos 3.1.01 works fine with the combination of CUDA 11 and -std=c++17 here.

Which leaves the (builds of) cuda and cudauvm programs to break until they have been migrated to the changes. Maybe we can live a short period of time with them broken.

src/cuda/CUDACore/deviceAllocatorStatus.cc

src/cuda/CUDACore/deviceAllocatorStatus.h

src/cudadev/CUDACore/deviceAllocatorStatus.cc

src/cudadev/CUDACore/deviceAllocatorStatus.h

makortel · 2020-11-05T17:38:07Z

src/cudadev/test/HistoContainer_t_cpu.cc

@@ -135,6 +138,8 @@ void go() {
 }

 int main() {
+  cms::cudatest::requireDevices();


Why does this test require devices? It is supposed to run on CPU.

Good point.
It's like this in CMSSW, but I agree the requirement should be removed.

makortel · 2020-11-05T17:41:21Z

src/cudadev/test/TrackingRecHit2DCUDA_t.cu

@@ -0,0 +1,56 @@
+#include "CUDADataFormats/TrackingRecHit2DCUDA.h"


Future note: this file is from cuda instead of CMSSW

makortel · 2020-11-05T17:41:38Z

src/cudadev/test/TrajectoryStateSOA_t.h

@@ -0,0 +1,75 @@
+#include "CUDADataFormats/TrajectoryStateSoA.h"


Future note: this file is from cuda instead of CMSSW.

makortel · 2020-11-05T18:49:01Z

src/cudadev/test/histo.cc

+#include <iostream>
+#include <sstream>
+
+#include "plugin-Validation/SimpleAtomicHisto.h"


For future reference, this is from cuda instead of CMSSW

makortel · 2020-11-05T18:50:14Z

src/cudadev/test/testBrokenLineFit.cc

@@ -0,0 +1,2 @@
+#define USE_BL
+#include "testRiemannFit.cc"


For future reference: this file is from cuda instead of CMSSW

Highlights: - remove the dependency on the CUB external - reduce caching allocator memory usage - update CUDA to version 11.0 and C++17 - update the code base from CMSSW 11.2.0-pre8

fwyzard · 2020-11-05T23:08:33Z

I've tried to separate the files from cuda instead of from CMSSW to a second commit

makortel · 2020-11-10T02:07:30Z

(I'm still running tests before hitting the merge button)

makortel · 2020-11-10T19:10:15Z

The alpaka and alpakatest fail to build with

.../pixeltrack-standalone/external/alpaka/include/alpaka/core/Concepts.hpp:81:33: error: '__T0' was not declared in this scope
                 static_assert(std::is_base_of<type, TDerived>::value, "The type implementing the concept has to be a publicly accessible base class!");
                                 ^~~~
.../pixeltrack-standalone/external/alpaka/include/alpaka/core/Concepts.hpp:81:33: note: suggested alternative: '__y0'
                 static_assert(std::is_base_of<type, TDerived>::value, "The type implementing the concept has to be a publicly accessible base class!");
                                 ^~~~
                                 __y0
.../pixeltrack-standalone/external/alpaka/include/alpaka/core/Concepts.hpp:81:47: error: template argument 1 is invalid
                 static_assert(std::is_base_of<type, TDerived>::value, "The type implementing the concept has to be a publicly accessible base class!");

Updating Alpaka to 0.5.0 changed the error to

.../pixeltrack-standalone/external/alpaka/include/alpaka/core/UniformCudaHip.hpp: In instantiation of 'void alpaka::uniform_cuda_hip::detail::rtCheckIgnore(const Error_t&, const char*, const char*, const int&, TErrors&& ...) [with TErrors = {cudaError}; alpaka
::uniform_cuda_hip::detail::Error_t = cudaError]':
.../pixeltrack-standalone/external/alpaka/include/alpaka/queue/cuda_hip/QueueUniformCudaHipRtBase.hpp:196:342:   required from here
.../pixeltrack-standalone/external/alpaka/include/alpaka/core/UniformCudaHip.hpp:86:61: error: missing braces around initializer for 'std::__array_traits<cudaError, 1>::_Type' {aka 'cudaError [1]'} [-Werror=missing-braces]
                     std::array<Error_t, sizeof...(ignoredErrorCodes)> const aIgnoredErrorCodes{ignoredErrorCodes...};
                                                             ^~~~~~~~~~~~~~~~~~

which can be worked around. (FYI @ghugo83)

I think this PR can move forward now, and then I/we'll address the issues to bring cuda, cudauvm, alpakatest, and alpaka back to life.

…g/running problems with CUDA11

fwyzard force-pushed the cudadev-update-CMSSW_11_2_0_pre8_Patatrack branch from 56003a9 to 7de7cee Compare November 5, 2020 14:57

fwyzard changed the title ~~[CUDADEV] Update to the code base from the Patatrack CMSSW release~~ Update to the code base from the Patatrack CMSSW release Nov 5, 2020

fwyzard force-pushed the cudadev-update-CMSSW_11_2_0_pre8_Patatrack branch from 7de7cee to 5b720d5 Compare November 5, 2020 16:51

makortel requested changes Nov 5, 2020

View reviewed changes

makortel mentioned this pull request Nov 5, 2020

Changes in #120 that need to be propagated elsewhere #121

Open

24 tasks

makortel added cuda general labels Nov 5, 2020

fwyzard force-pushed the cudadev-update-CMSSW_11_2_0_pre8_Patatrack branch from 5b720d5 to ccba578 Compare November 5, 2020 22:51

fwyzard added 2 commits November 6, 2020 00:06

[cudadev] Update to the code base from the Patatrack CMSSW release

5b39aa9

Highlights: - remove the dependency on the CUB external - reduce caching allocator memory usage - update CUDA to version 11.0 and C++17 - update the code base from CMSSW 11.2.0-pre8

[cudadev] Update plugins and tests from the "cuda" directory

eda7d59

fwyzard force-pushed the cudadev-update-CMSSW_11_2_0_pre8_Patatrack branch from ccba578 to eda7d59 Compare November 5, 2020 23:07

makortel self-requested a review November 10, 2020 02:06

makortel approved these changes Nov 10, 2020

View reviewed changes

makortel added 2 commits November 10, 2020 20:11

Update README

18fa006

Temporarily disable alpaka,alpakatest,cuda,cudauvm because of buildin…

e7c8026

…g/running problems with CUDA11

makortel merged commit 312ba67 into cms-patatrack:master Nov 10, 2020

This was referenced Nov 10, 2020

alpakatest and alpaka fail to build #126

Closed

cuda and cudadev fail to run #127

Closed

[cuda] Update code base to CMSSW_11_2_0_pre8_Patatrack #129

Merged

[cudauvm] Update code base to CMSSW_11_2_0_pre8_Patatrack #133

Merged

fwyzard deleted the cudadev-update-CMSSW_11_2_0_pre8_Patatrack branch December 7, 2020 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to the code base from the Patatrack CMSSW release #120

Update to the code base from the Patatrack CMSSW release #120

fwyzard commented Nov 5, 2020

makortel left a comment

makortel Nov 5, 2020

makortel Nov 5, 2020

makortel Nov 5, 2020

makortel Nov 5, 2020

fwyzard Nov 5, 2020

makortel Nov 5, 2020

makortel Nov 5, 2020

makortel Nov 5, 2020

makortel Nov 5, 2020

fwyzard commented Nov 5, 2020

makortel commented Nov 10, 2020

makortel commented Nov 10, 2020

		@@ -0,0 +1,56 @@
		#include "CUDADataFormats/TrackingRecHit2DCUDA.h"

		@@ -0,0 +1,75 @@
		#include "CUDADataFormats/TrajectoryStateSoA.h"

Update to the code base from the Patatrack CMSSW release #120

Update to the code base from the Patatrack CMSSW release #120

Conversation

fwyzard commented Nov 5, 2020

makortel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwyzard commented Nov 5, 2020

makortel commented Nov 10, 2020

makortel commented Nov 10, 2020