forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Pixel-ClusterLess reconstruction #541
Open
VinInn
wants to merge
79
commits into
cms-patatrack:CMSSW_11_1_X_Patatrack
Choose a base branch
from
VinInn:ClusterLess12
base: CMSSW_11_1_X_Patatrack
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RFC] Pixel-ClusterLess reconstruction #541
VinInn
wants to merge
79
commits into
cms-patatrack:CMSSW_11_1_X_Patatrack
from
VinInn:ClusterLess12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE:
this PR is mostly in support for the presentation at Pixel DPG on Wed 26/08/2020
https://indico.cern.ch/event/934821/#50-digiless-aka-clusterless-tr
This PR consists in three major modifications of some very basic/fundamental components of CMS tracker/tracking software implementation.
make MeasurementDet and some of its ancillary producers (ClusterRemoval) to consume RecHIts instead of Clusters
this is purely technical as RecHits are just a proxy to the Clusters
to prepare for next final step, RecHits have been sorted in "x" and is this sorting (and not the cluster sorting by firstRow) that is used in the MeasurementDet: so some regression is expected
Make the OmniRef to "reference" an item in a SoA (it is actually very general) and (if this is the case) make GenericCPE to consume the SoA when "improving" the hits using the track angle
Both these changes are fully backward compatible (requires customization of existing HLT menus) and should actually be applied upstream to standard CMSSW
fix code (in particular MeasurementDet and Validation) to work with "cluster-less" hits
at this point one can drop the conversion to LegacyCluster in patatrack workflows (in case of unscheduled will happen w/o any further intervention)
Please refer to the inlined comments and the presentation referred above for further details.
It also includes code from #528
The way this code will then materialize in actual PRs is open to suggestions and comments
(contrary to most patatrack code it affects mainstream classes belonging mostly to Tracking-POG)