Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Pixel-ClusterLess reconstruction #541

Open
wants to merge 79 commits into
base: CMSSW_11_1_X_Patatrack
Choose a base branch
from

Conversation

VinInn
Copy link

@VinInn VinInn commented Aug 25, 2020

DO NOT MERGE:
this PR is mostly in support for the presentation at Pixel DPG on Wed 26/08/2020
https://indico.cern.ch/event/934821/#50-digiless-aka-clusterless-tr

This PR consists in three major modifications of some very basic/fundamental components of CMS tracker/tracking software implementation.

  1. make MeasurementDet and some of its ancillary producers (ClusterRemoval) to consume RecHIts instead of Clusters
    this is purely technical as RecHits are just a proxy to the Clusters
    to prepare for next final step, RecHits have been sorted in "x" and is this sorting (and not the cluster sorting by firstRow) that is used in the MeasurementDet: so some regression is expected

  2. Make the OmniRef to "reference" an item in a SoA (it is actually very general) and (if this is the case) make GenericCPE to consume the SoA when "improving" the hits using the track angle

Both these changes are fully backward compatible (requires customization of existing HLT menus) and should actually be applied upstream to standard CMSSW

  1. add a conditional path in the PixelRecHitFromSoA to make RecHits to point to SoA and not to clusters
    fix code (in particular MeasurementDet and Validation) to work with "cluster-less" hits
    at this point one can drop the conversion to LegacyCluster in patatrack workflows (in case of unscheduled will happen w/o any further intervention)

Please refer to the inlined comments and the presentation referred above for further details.

It also includes code from #528

The way this code will then materialize in actual PRs is open to suggestions and comments
(contrary to most patatrack code it affects mainstream classes belonging mostly to Tracking-POG)

@VinInn VinInn added new feature Pixels Pixels-related developments labels Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Pixels Pixels-related developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants