Small fix in getGlobalBin #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaldu
force-pushed
the
fix-getglobalbin
branch
from
5a7cf44 to
b1621ef
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (int i{1}; i != Ndim; ++i) { | ||
| globalBin += n_tiles_per_dim * getBin(acc, coords[i], i); | ||
| int globalBin = 0; | ||
| for (int dim = 0; dim != Ndim - 1; ++dim) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| } | ||
| globalBin += getBin(acc, coords[Ndim - 1], Ndim - 1); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule Note
| uint32_t globalBin{Bins[0]}; | ||
| for (int i{1}; i != Ndim; ++i) { | ||
| globalBin += n_tiles_per_dim * Bins[i]; | ||
| const TAcc& acc, const VecArray<uint32_t, Ndim>& Bins) const { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule Note
| globalBin += n_tiles_per_dim * Bins[i]; | ||
| const TAcc& acc, const VecArray<uint32_t, Ndim>& Bins) const { | ||
| uint32_t globalBin = 0; | ||
| for (int dim = 0; dim != Ndim - 1; ++dim) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
sbaldu
added a commit
to sbaldu/CLUEstering
that referenced
this pull request
Jan 14, 2025
* Small fix in getGlobalBin * Update version * Formatting Fix after merge
sbaldu
added a commit
that referenced
this pull request
Jan 14, 2025
* Rework points as SoA Update backend code Update binding modules Update python API Add tests for host-side point SoA Update run_clue for CUDA and HIP Update benchmarking scripts Move test folder Fix device memory access in memcpy * Feature clusterer import method (#76) * Add `import_clusterer` method * Add test for new clusterer import * Add docstring * Fix "if main" of test file * Addition to gitignore * Small fix in getGlobalBin (#75) * Small fix in getGlobalBin * Update version * Formatting Fix after merge * Separate alpaka input and result buffers Fix partial dimensional clustering Update package version
sbaldu
added a commit
to sbaldu/CLUEstering
that referenced
this pull request
Jan 15, 2025
* Small fix in getGlobalBin * Update version * Formatting
sbaldu
added a commit
to sbaldu/CLUEstering
that referenced
this pull request
Jan 15, 2025
* Rework points as SoA Update backend code Update binding modules Update python API Add tests for host-side point SoA Update run_clue for CUDA and HIP Update benchmarking scripts Move test folder Fix device memory access in memcpy * Feature clusterer import method (cms-patatrack#76) * Add `import_clusterer` method * Add test for new clusterer import * Add docstring * Fix "if main" of test file * Addition to gitignore * Small fix in getGlobalBin (cms-patatrack#75) * Small fix in getGlobalBin * Update version * Formatting Fix after merge * Separate alpaka input and result buffers Fix partial dimensional clustering Update package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.