Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test file for DataFormats/L1Scouting #1

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

Mmiglio
Copy link
Contributor

@Mmiglio Mmiglio commented Dec 20, 2023

Add initial data files that will be used in a unit test of the L1 Scouting data formats. These will be read by future releases to verify backward compatibility.

This is related to cms-sw/cmssw#43467. I will open a new PR with improved unit tests for data format.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mmiglio (Matteo Migliorini) for branch main.

@aandvalenzuela, @smuzaffar, @emeschi, @iarspider, @cmsbuild, @smorovic can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 20, 2023

cms-bot internal usage

@smorovic
Copy link

please test

@smorovic
Copy link

+daq
(tests still running, but I guess new root file shouldn't in fact have effect)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ac934/36617/summary.html
COMMIT: bdcde0b
CMSSW: CMSSW_14_0_X_2023-12-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/DataFormats-L1Scouting/1/36617/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ac934/36617/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ac934/36617/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@Mmiglio
Copy link
Contributor Author

Mmiglio commented Jan 16, 2024

Hi all, is there anything missing for this PR to be merged?
I assume I need to wait for this PR to be merged before adding the test to CMSSW.
The same question applies to cms-data/DataFormats-L1ScoutingRawData#1.

@smuzaffar
Copy link
Contributor

only new data file, so I am merging it now

@smuzaffar smuzaffar merged commit 1d6c4d1 into cms-data:main Jan 19, 2024
9 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow the naming convention in DataFormats/Scouting, please rename the file as testL1Scouting_v3_v3_v3_v3_v3_13_3_0_pre5.root to include the versions of each the classes. The order should reflect the order of the classes in the DataFormats/L1Scouting/src/classes_def.xml, which I'd also ask to be reordered in alphabetical order in the PR that adds the tests using this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants