Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove tool_choice in model callback input #62

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

N3kox
Copy link
Contributor

@N3kox N3kox commented Jan 15, 2025

What type of PR is this?

refactor: remove tool_choice in model callback input,support tools and tool_choice from call option

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

移除 callback input 中的 tool choice
支持应用 call options 中的 tools 和 tool choice

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

go-test-coverage report:

No coverage report available ```

@N3kox N3kox force-pushed the refactor/tool_choice branch 2 times, most recently from 507273c to 058e1c9 Compare January 20, 2025 06:52
@N3kox N3kox marked this pull request as draft January 21, 2025 06:40
@N3kox N3kox force-pushed the refactor/tool_choice branch 2 times, most recently from 7e51796 to ee0ff42 Compare January 23, 2025 09:22
@N3kox N3kox force-pushed the refactor/tool_choice branch from ee0ff42 to 45af026 Compare February 7, 2025 03:28
@N3kox N3kox marked this pull request as ready for review February 7, 2025 03:37
@N3kox N3kox force-pushed the refactor/tool_choice branch from 45af026 to c1da3de Compare February 7, 2025 07:30
Copy link
Contributor

@meguminnnnnnnnn meguminnnnnnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM'

@N3kox N3kox merged commit 4b90fcb into main Feb 8, 2025
4 checks passed
@N3kox N3kox deleted the refactor/tool_choice branch February 8, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants