me-17969: test if video on playlist by tag page is playing #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refael-m
reviewed
Jan 5, 2025
| @@ -12,7 +12,9 @@ vpTest(`Test if 4 videos on Cloudinary analytics page are playing as expected`, | |||
| await waitForPageToLoadWithTimeout(page, 5000); | |||
| }); | |||
| await test.step('Validating that Cloudinary analytics video is playing', async () => { | |||
| await pomPages.cldAnalyticsPage.cldAnalyticsVideoComponent.validateVideoIsPlaying(true); | |||
| await expect(async () => { | |||
There was a problem hiding this comment.
why did you add wrap it with toPass?
There was a problem hiding this comment.
Cloudinary Analytics page video spec was failing and failed the PR. It takes some time to the video start playing so I added toPass to the first video and it works. After discussion the toPass wrap moved to validateVideoIsPlaying inside as part of the video component.
refael-m
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17969
This test is navigating to playlist by tag page (playlist-by-tag-captions.html) and make sure that video element is playing.