Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me 17964 - floating player page video playing #776

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

ShayLevi
Copy link
Contributor

@ShayLevi ShayLevi commented Jan 1, 2025

Relevant task - https://cloudinary.atlassian.net/browse/ME-17964
This test is navigating to floating player page (floating-player.html) and make sure that video element is playing.

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 291f00d
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/6776368c3043530008c37d7c
😎 Deploy Preview https://deploy-preview-776--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 291f00d
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6776368c6cfcc600088adcdf
😎 Deploy Preview https://deploy-preview-776--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShayLevi ShayLevi marked this pull request as draft January 1, 2025 13:58
@ShayLevi ShayLevi marked this pull request as ready for review January 1, 2025 14:03
@ShayLevi ShayLevi requested a review from a team as a code owner January 1, 2025 14:03

/**
* Video player examples floating player page object
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Floating player page object'
is better

@ShayLevi ShayLevi merged commit ea8c5ae into edge Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants