remove usage of flag

cloudfoundry · Apr 17, 2024 · 3816c71 · 3816c71
1 parent b207b1e
commit 3816c71
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...java/org/cloudfoundry/multiapps/controller/process/steps/PollStartAppStatusExecution.java b/...java/org/cloudfoundry/multiapps/controller/process/steps/PollStartAppStatusExecution.java
@@ -80,8 +80,6 @@ private CloudApplication getApplication(ProcessContext context, String appToPoll
     }
 
     private StartupStatus getStartupStatus(ProcessContext context, String appName, List<InstanceInfo> appInstances) {
-        boolean failOnCrashed = context.getVariable(Variables.FAIL_ON_CRASHED);
-
         int expectedInstances = appInstances.size();
         long runningInstances = getInstanceCount(appInstances, InstanceState.RUNNING);
         long downInstances = getInstanceCount(appInstances, InstanceState.DOWN);
@@ -102,7 +100,7 @@ private StartupStatus getStartupStatus(ProcessContext context, String appName, L
         if (downInstances > 0) {
             return StartupStatus.DOWN;
         }
-        if (crashedInstances > 0 && failOnCrashed) {
+        if (crashedInstances > 0) {
             return StartupStatus.CRASHED;
         }
         return StartupStatus.STARTING;

diff --git a/.../org/cloudfoundry/multiapps/controller/process/steps/PollStartAppStatusExecutionTest.java b/.../org/cloudfoundry/multiapps/controller/process/steps/PollStartAppStatusExecutionTest.java
@@ -71,7 +71,7 @@ static Stream<Arguments> testStep() {
         return Stream.of(Arguments.of(List.of(InstanceState.RUNNING, InstanceState.STARTING), true, AsyncExecutionState.RUNNING),
                          Arguments.of(List.of(InstanceState.CRASHED, InstanceState.CRASHED, InstanceState.CRASHED), true,
                                       AsyncExecutionState.ERROR),
-                         Arguments.of(List.of(InstanceState.CRASHED), false, AsyncExecutionState.RUNNING),
+                         Arguments.of(List.of(InstanceState.CRASHED), false, AsyncExecutionState.ERROR),
                          Arguments.of(List.of(InstanceState.DOWN, InstanceState.RUNNING), true, AsyncExecutionState.ERROR),
                          Arguments.of(List.of(InstanceState.RUNNING, InstanceState.RUNNING), true, AsyncExecutionState.FINISHED));
     }