Optimize list operations for space scoped resrouces #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webhook * Defaults the space-guid label * Ensures that the label value is immutable Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
- Separate the client factory into two separate ones: UserClientFactory and UserClientsetFactory. The latter is barely used - Introdue space filtering client wrapper - Make it possible to add wreppers to the user client returned by the UserClientFactory. We have retrying client and space filetering client wrappers as of today - Use the new space filtering wrapper in all repositores that operate on spece scoped resources - This results in optimization of resource listing as well as reduction in code duplication - The wrapped client automatically filters the listed resources to the ones from the allowed namespaces Co-authored-by: Danail Branekov <[email protected]> Co-authored-by: Georgi Sabev <[email protected]>
- Generate manifests only for the webhooks we are about to test - Do not wire in unrelated webhooks in the test suite Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
issues/3636-improve-listing
branch
from
b06cdec to
77cb45e
Compare
danail-branekov
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3636
What is this change about?
Does this PR introduce a breaking change?
No