Fix PaidServicesAllowed to type bool #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LGTM, I can merge it if you sign the CLA |
|
as a little time has already passed, a short feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cloud Controller API states that the PaidServicesAllowed field must not be null.
The field should be a boolean and not a *bool (pointer).
https://v3-apidocs.cloudfoundry.org/version/3.180.0/index.html#the-organization-quota-object
This way, the calling application can assume that it is not nil.
The other fields are designated as nullable or pointers and thus defined as unlimited.
This makes no sense for a boolean.
Other use cases also follow this pattern: pointer = nullable, otherwise value.
Therefore, I assume that this is a bug, which I fix with this PR.
Currently, the command
make allthrows lint warnings, which also happens to me in the main branch.