WIP: Add B3 trace IDs to cf cli commands #3310
Draft
+572
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3309
Description of the Change
The CLI now sets the B3_TRACE headers as per https://docs.cloudfoundry.org/adminguide/distributed-tracing.html#unique-trace-id.
Notes:
X-B3-Traceid
header for all API requests initiated by that CF command. (e.g. use the same header for all api calls for the commandcf apps
).X-B3-Spanid
per API request.CF_B3_TRACE_ID
that allows theX-B3-Traceid
to be overridden.X-Vcap-Request-Id
to the same header as theX-B3-Traceid
(in uuid v4 format) and will work withW3C
headers if `router.tracing.enable_w3c is set.CF_TRACE
or-v
Why Is This PR Valuable?
See #3309
Examples
With auto-generated headers:
With environment variable override: