-
Notifications
You must be signed in to change notification settings - Fork 324
Major performance boost. Fix #126 #444
base: master
Are you sure you want to change the base?
Conversation
…ve setElement to do the actual setting of this.el
Hi @wyuenho When do you plan to merge this work ? |
Pending for jashkenas/backbone#3003. So as soon as Backbone makes a move towards 1.2 I'll fix this branch up and merge this. |
Ah sorry I've just found your great work on Backbone repository. Thank you ! |
Good work! I love this plugin! @wyuenho do you know when you will merge? because i really need this performance... Thanks! |
@wyuenho It appears jashkenas/backbone#3003 and jashkenas/backbone#3006 were both merged. Do you think we can merge this? |
any update on this? |
@wyuenho - Can this be merged? |
@wyuenho it's just now been a full year since the last release... this pull sounds really good.. isn't it time you made a new release :) are you still alive? |
It looks like this needs to be adapted for jashkenas/backbone#3003 which got merged instead of jashkenas/backbone#2959? |
Backbone 1.2 is out with the necessary jQuery-agnostic changes to allow this PR to be merged. |
+1 |
We could use this as well. We have some complex backgids that will benefit from this change a lot. |
+1 |
2 similar comments
+1 |
+1 |
+1 would be absolutely awesome to finally see this enhancement merged! |
+1 Can't wait to see this in master branch! |
+1 |
2 similar comments
+1 |
+1 |
Any update on this merge? Seems like it could only be a good thing.. |
For those who want to get this merged. I can use some help here.
Any help other than +1 will greatly accelerate this effort. |
+1 |
This major refactoring for #126 boosts performance by 70% - 75% across browsers by introducing a custom
Backgrid.View
and having all Backgrid components inherit from it.Backgrid.View
closely resemblesBackbone.View
's semantics with the exception that it isn't backed by jQuery. Sorting and rerendering the first 242 x 6 grid example on backgridjs.com takes 100 - 150ms on my Macbook Pro Retina 2012 with 2.7GHz i7 CPU. Dramatic improvement over 500 - 700ms with the latest release.This branch has been tested successfully on all desktop browsers: IE8+, lastest versions of Firefox, Safari, Chrome and Opera. IE8 support will be downgraded and a
classList
shim is required now for IE<10. All tests still pass for IE<10 however once aclassList
polyfill is in place.TODO:
Backgrid.View
will stay or go, and how much shimming is required for IE8 depends on whether the PR gets merged.Interested parties please help review this code.