Add configurable not-before delay #77
Merged
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RageKnify
reviewed
Jan 6, 2025
This commit adds `KEY_NOT_BEFORE_DELAY_IN_MS` binding. This is the delay that is going to be added when generating key to their `notBefore` parameter. This allow a key to be generated at time `t` to not be valid before `t+KEY_NOT_BEFORE_DELAY_IN_MS`. Key rotation and tests are updated accordingly. This is backward compatible with deployed codebase, defaulting to `KEY_NOT_BEFORE_DELAY_IN_MS=0` which was the previous behaviour.
thibmeu
force-pushed
the
add-configurable-not-before-delay
branch
from
b5e80e9 to
99d4fa4
Compare
ThePlexus
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
KEY_NOT_BEFORE_DELAY_IN_MSbinding. This is the delay that is going to be added when generating key to theirnotBeforeparameter. This allow a key to be generated at timetto not be valid beforet+KEY_NOT_BEFORE_DELAY_IN_MS.Key rotation and tests are updated accordingly.
This is backward compatible with deployed codebase, defaulting to
KEY_NOT_BEFORE_DELAY_IN_MS=0which was the previous behaviour.