Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-11539 - Terraform does not support http and https proxy #89

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Mar 5, 2024

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gregito gregito requested a review from a team as a code owner March 5, 2024 11:21
Copy link

github-actions bot commented Mar 5, 2024

Go test coverage: 31.5% for commit 46e6658
⚠️ 2 of 9 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.9%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    45.5%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    45.7%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

@gregito gregito linked an issue Mar 5, 2024 that may be closed by this pull request
@gregito gregito enabled auto-merge (rebase) March 5, 2024 12:09
@keyki keyki self-requested a review March 5, 2024 12:26
@keyki keyki disabled auto-merge March 5, 2024 12:27
@keyki keyki enabled auto-merge (squash) March 5, 2024 12:27
Copy link

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@keyki keyki merged commit 22ad66a into main Mar 6, 2024
6 checks passed
@gregito gregito deleted the CDPCP-11539 branch March 6, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Proxy not supported
3 participants