Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGESC-23979 - Unable to create Data lake and Data hub cluster through Terraform #85

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Feb 20, 2024

No description provided.

Copy link

github-actions bot commented Feb 20, 2024

Go test coverage: 31.5% for commit 114e968
⚠️ 2 of 9 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.6%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    45.5%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    45.7%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

@gregito gregito marked this pull request as ready for review February 20, 2024 17:08
@gregito gregito requested a review from a team as a code owner February 20, 2024 17:08
@gregito gregito enabled auto-merge (rebase) February 20, 2024 22:24
Copy link
Contributor

@balazsgaspar balazsgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some further refactoring of generic vs the cloud-specific model & schema might be useful in the next release.

@gregito gregito merged commit 4b54cd2 into main Feb 26, 2024
2 checks passed
@gregito gregito deleted the ENGESC-23979 branch February 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants