Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWX-18763: VW Impala create and delete using basic properties #179

Closed
wants to merge 14 commits into from
Closed

DWX-18763: VW Impala create and delete using basic properties #179

wants to merge 14 commits into from

Conversation

prateek1192
Copy link
Contributor

@prateek1192 prateek1192 commented Nov 20, 2024 •
edited
Loading

This commit adds the Impala resource and adds the basic required properties and also adds the image_version for it.

@prateek1192 prateek1192 requested a review from a team as a code owner November 20, 2024 00:06
@prateek1192 prateek1192 force-pushed the dwx-18763 branch 2 times, most recently from 8dd6928 to 4253800 Compare November 20, 2024 01:09
tevesz
tevesz reviewed Nov 26, 2024
View reviewed changes
docs/resources/vw_impala.md Outdated Show resolved Hide resolved
tevesz
tevesz reviewed Nov 26, 2024
View reviewed changes
docs/resources/vw_impala.md Outdated Show resolved Hide resolved
@prateek1192 prateek1192 force-pushed the dwx-18763 branch 3 times, most recently from 01a6abb to 6550188 Compare December 9, 2024 09:25
tevesz
tevesz reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tevesz tevesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description of the change

tevesz
tevesz reviewed Dec 10, 2024
View reviewed changes
provider/provider.go Outdated Show resolved Hide resolved
tevesz
tevesz reviewed Dec 10, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@prateek1192 prateek1192 changed the title WIP: DWX-18763: VW Impala create and delete using basic properties DWX-18763: VW Impala create and delete using basic properties Dec 10, 2024
@prateek1192 prateek1192 requested a review from tevesz December 11, 2024 08:02
tevesz
tevesz reviewed Dec 12, 2024
View reviewed changes
resources/dw/virtualwarehouse/impala/resource_impala_vw.go Outdated
}

impala := describe.GetPayload()
plan.ID = types.StringValue(impala.Vw.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a method on resourceModel to populate the plan data, you can leave then this piece in the caller function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

@prateek1192 prateek1192 requested a review from tevesz December 13, 2024 10:05
@prateek1192 prateek1192 requested a review from tevesz December 16, 2024 22:21
@prateek1192 prateek1192 requested a review from tevesz December 17, 2024 00:49
@prateek1192 prateek1192 deleted the dwx-18763 branch December 19, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcsomor vcsomor Awaiting requested review from vcsomor

@gregito gregito Awaiting requested review from gregito

@tevesz tevesz Awaiting requested review from tevesz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prateek1192 @tevesz @gregito @vcsomor @prateekcldr