Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-11759 Preventing duplicated set element error in DL creation #104

Merged
merged 1 commit into from
Apr 4, 2024
Merged

CDPCP-11759 Preventing duplicated set element error in DL creation #104

merged 1 commit into from
Apr 4, 2024

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Apr 3, 2024

  • instances without id are no longer saved to state, to prevent duplicated set element issue
  • default DL polling time increased to 90 minutes, as creation often takes more than 1 hour
  • Added nil check to AWS CloudProviderConfiguration conversion
  • Removed endpoint conversion from GCP DL converter as it is dead code

@daszabo daszabo requested a review from a team as a code owner April 3, 2024 14:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Go test coverage: 33.3% for commit 10f8487
⚠️ 2 of 10 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    37.4%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     7.8%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    47.5%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb         |     2.5%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    45.2%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    68.8%

@daszabo
CDPCP-11759 Preventing duplicated set element error in DL creation
19bc4b1 
- instances without id are no longer saved to state, to prevent duplicated set element issue
- default DL polling time increased to 90 minutes, as creation often takes more than 1 hour
- Added nil check to AWS CloudProviderConfiguration conversion
- Removed endpoint conversion from GCP DL converter as it is dead code
gregito
gregito approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gregito gregito merged commit 2b1ab4c into main Apr 4, 2024
6 checks passed
@gregito gregito deleted the CDPCP-11759 branch April 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregito gregito gregito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daszabo @gregito