Fix/version #36
Open
Fix/version #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13archit
reviewed
Sep 16, 2024
main.tf
Outdated
| category_group = "AllLogs" | ||
| enabled = true | ||
| enabled_log { | ||
| category = "FirewallNetworkRule" |
13archit
reviewed
Sep 16, 2024
main.tf
Outdated
|
|
||
| log { | ||
| enabled_log { | ||
| category = "FirewallApplicationRule" |
13archit
reviewed
Sep 16, 2024
main.tf
Outdated
| days = var.days | ||
| } | ||
| enabled_log { | ||
| category = "FirewallThreatIntel" |
d4kverma
reviewed
Sep 18, 2024
| name = local.name | ||
| environment = local.environment | ||
| label_order = ["name", "environment"] | ||
| create_log_analytics_workspace = true | ||
| log_analytics_workspace_sku = "PerGB2018" | ||
| resource_group_name = module.resource_group.resource_group_name | ||
| log_analytics_workspace_location = module.resource_group.resource_group_location | ||
| log_analytics_workspace_id = module.log-analytics.workspace_id |
There was a problem hiding this comment.
why are you passing "log-analytics" id and same module. Plesae explain .
d4kverma
reviewed
Sep 18, 2024
main.tf
Outdated
| } | ||
| } | ||
|
|
||
| dynamic "ip_configuration" { | ||
| for_each = toset(var.additional_public_ips) | ||
|
|
||
| content { | ||
| name = lookup(ip_configuration.value, "name") | ||
| public_ip_address_id = lookup(ip_configuration.value, "public_ip_address_id") | ||
| name = lookup(ip_configuration.value, "name", null) |
There was a problem hiding this comment.
@13archit check here please why he is adding null value for default case .
13archit
reviewed
Sep 24, 2024
examples/complete/example.tf
Outdated
| #subnet | ||
| specific_name_subnet = true | ||
| specific_subnet_names = "AzureFirewallSubnet" | ||
| specific_subnet_names = ["AzureFirewallSubnet"] # Corrected to be a list of strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
Update version for removinge block errors and deprecations
addad versions.tf for define azurerm version
references