Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix- Fixed typo for external EBS attachment block. #64

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix- Fixed typo for external EBS attachment block. #64

merged 2 commits into from
Jan 12, 2024

Conversation

nileshgadgi
Copy link
Contributor

what

  • Fixed Typo of External Volume attachment.

why

  • Was getting error while attaching external volume to ec2 instance.

@nileshgadgi nileshgadgi added the bug Something isn't working label Jan 12, 2024
@nileshgadgi nileshgadgi self-assigned this Jan 12, 2024
vaibhav7797
vaibhav7797 previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vaibhav7797
vaibhav7797 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

theprashantyadav
theprashantyadav approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@theprashantyadav theprashantyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themaniskshah themaniskshah merged commit 31ab62b into master Jan 12, 2024
19 checks passed
@themaniskshah themaniskshah deleted the fix/typo branch January 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@theprashantyadav theprashantyadav theprashantyadav approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nileshgadgi @themaniskshah @theprashantyadav @vaibhav7797 @anmolnagpal